utils: run commands using utf-8 string on Windows
ClosedPublic
Actions

Authored by Fabien on Jun 9 2019, 06:43.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING897e59d0af84: utils: run commands using utf-8 string on Windows
rABC897e59d0af84: utils: run commands using utf-8 string on Windows

Summary

Use unicode string to call commans

Backport of core PR13886
https://github.com/bitcoin/bitcoin/pull/13886/files

Will fix gitian windows build issue introduced in D3241.

Test Plan

make check

Build for windows:

mkdir buildcmake && cd buildcmake
cmake -GNinja .. -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake \
-DBUILD_BITCOIN_SEEDER=OFF
ninja

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13886

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6235
Build 10517: Bitcoin ABC Buildbot (legacy)
Build 10516: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 9 2019, 06:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2019, 06:43

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6235: Diff 9273.Jun 9 2019, 06:50

jasonbcox accepted this revision.Jun 9 2019, 14:42

This revision is now accepted and ready to land.Jun 9 2019, 14:42

Closed by commit rABC897e59d0af84: utils: run commands using utf-8 string on Windows (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by Fabien). · Explain WhyJun 9 2019, 15:37

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC897e59d0af84: utils: run commands using utf-8 string on Windows.

Fabien added a commit: rSTAGING897e59d0af84: utils: run commands using utf-8 string on Windows.Sep 19 2019, 00:10

Revision Contents
Changeset List

Path

Size

src/

util.cpp

8 lines

Diff 9273

View Options

utils: run commands using utf-8 string on WindowsClosedPublicActions