Paths

Table of Contentst

Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json
ClosedPublic
Actions

Authored by jasonbcox on Jun 10 2019, 20:48.

Details

Reviewers

deadalnix
Fabien
markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGINGacb45f2c4e35: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.
rABCacb45f2c4e35: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.

Summary

988ce2d Adding 'amount' label to tx_valid/tx_invalid.json files (Chris Stewart)

Tree-SHA512: 11c216c6565ecaa5ff4eb6122f87d3b28f89db52d1e473c0678f61c240e133698adb05e717bfb9d3db36409dfb230b902dca4029a58633be36c9f85e0db3d973

Backport of Core PR9350

https://github.com/bitcoin/bitcoin/pull/9350/files

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr9350

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6253
Build 10553: Bitcoin ABC Buildbot (legacy)
Build 10552: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jun 10 2019, 20:48

Herald added a reviewer: deadalnix. · View Herald TranscriptJun 10 2019, 20:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6253: Diff 9295.Jun 10 2019, 20:54

Hmm looks like transaction_tests.cpp (e.g., BOOST_AUTO_TEST_CASE(tx_invalid) comment) needs to be updated as well.

Agree with @markblundeberg's comment, but can be a follow up.

This revision is now accepted and ready to land.Jun 11 2019, 06:03

markblundeberg accepted this revision.Jun 11 2019, 13:18

Closed by commit rABCacb45f2c4e35: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid. (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyJun 11 2019, 16:23

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCacb45f2c4e35: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid..

jasonbcox added a commit: rSTAGINGacb45f2c4e35: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid..Sep 19 2019, 00:12

Revision Contents
Changeset List

Path

Size

src/

test/

data/

tx_invalid.json

2 lines

tx_valid.json

2 lines

Diff 9295

View Options

src/test/data/tx_invalid.json