Page MenuHomePhabricator

[LINTER] Fix some PHP linter rules
ClosedPublic

Authored by Fabien on Jun 11 2019, 13:54.

Details

Summary

Disable 2 generic rules:

  • The limit in cyclomatic complexity, whose value is not configurable.

Phabricator does not enforce this rule, and the hardcoded value is very
restrictive.

  • Enforce no space after a cast. Actually both 0 space and 1 space are

enforced, causing conflicts (there is no cast in the PHP codebase yet).

Test Plan
arc lint --everything

Should return no error.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
linter_phpcs_fix_rules
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6263
Build 10573: Bitcoin ABC Buildbot (legacy)
Build 10572: arc lint + arc unit