Page MenuHomePhabricator
Differential D3313

Make float <-> int casts explicit outside of test, qt, CFeeRate
ClosedPublic
Actions

Authored by Fabien on Jun 13 2019, 10:43.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING022cd307933d: Make float <-> int casts explicit outside of test, qt, CFeeRate
rABC022cd307933d: Make float <-> int casts explicit outside of test, qt, CFeeRate
Summary

Backport of core PR11303
Only the commit 53a6590 is applicable for us.
https://github.com/bitcoin/bitcoin/pull/11303/commits/53a6590f496b25174c740927243bf8307541b0b9

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11303
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6303
Build 10653: Bitcoin ABC Buildbot (legacy)
Build 10652: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 13 2019, 10:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2019, 10:43
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 13 2019, 10:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien mentioned this in D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).Jun 13 2019, 10:44
teamcity added a comment.Jun 13 2019, 10:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6303: Diff 9378.Jun 13 2019, 10:53
jasonbcox accepted this revision.Jun 14 2019, 00:34
This revision is now accepted and ready to land.Jun 14 2019, 00:34
Closed by commit rABC022cd307933d: Make float <-> int casts explicit outside of test, qt, CFeeRate (authored by Matt Corallo <git@bluematt.me>, committed by Fabien). · Explain WhyJun 14 2019, 07:28
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC022cd307933d: Make float <-> int casts explicit outside of test, qt, CFeeRate.
Fabien added a commit: rSTAGING022cd307933d: Make float <-> int casts explicit outside of test, qt, CFeeRate.Sep 19 2019, 00:18
PiRK mentioned this in D8110: feefilter: Compute the absolute fee rather than stored rate to match mempool acceptance logic.Oct 25 2020, 19:23
PiRK mentioned this in rABC22362253b49e: feefilter: Compute the absolute fee rather than stored rate to match mempool….Oct 26 2020, 20:40

Revision Contents
Changeset List

PathSize
src/
rpc/
3 lines
2 lines
wallet/
17 lines

Diff 9378

View Options

src/rpc/net.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...