Many peer will relay non replay protected transactions, so we want to be nice to them at least in the short term.
Details
Details
- Reviewers
freetrader sickpig kyuupichan - Group Reviewers
Restricted Project - Commits
- rSTAGING234a65d82f47: Be nice to peer that relay non replay protected transactions.
rABC234a65d82f47: Be nice to peer that relay non replay protected transactions.
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- nobanforkid
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 585 Build 585: arc lint + arc unit
Event Timeline
Comment Actions
Looks good to me.
| src/validation.cpp | ||
|---|---|---|
| 1417 ↗ | (On Diff #941) | It would be nice to add some more rationale to this comment, like what is written in the summary. Without it, it's difficult to understand why this code is here. And it would make more sense to me if this comment was moved to before check2 instantiational, or to right before if if() conditional. I prefer higher up though. |
Comment Actions
Agree an explanatory comment for the reason for the 2 checks is warranted. It's not obvious.