Page MenuHomePhabricator
Differential D3359

Replumb ibd.sh to prepare for better post-IBD checks
ClosedPublic
Actions

Authored by jasonbcox on Jun 17 2019, 22:50.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING88a45c98694f: Replumb ibd.sh to prepare for better post-IBD checks
rABC88a45c98694f: Replumb ibd.sh to prepare for better post-IBD checks
Summary

With the current design of ibd.sh, exiting the IBD subshell early (in the
future case of adding additional tests/checks) would result in bitcoind not exiting
as expected. This patch replumbs ibd.sh such that failures in the IBD subshell or
bitcoind properly fail the script as expected.

Post IBD checks will be added in an upcoming diff.

Test Plan

TeamCity IBD

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ibd-better-subshell
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6390
Build 10827: Bitcoin ABC Buildbot (legacy)
Build 10826: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jun 17 2019, 22:50
Herald added a reviewer: deadalnix. · View Herald TranscriptJun 17 2019, 22:50
jasonbcox planned changes to this revision.Jun 17 2019, 22:50
teamcity added a comment.Jun 17 2019, 22:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 17 2019, 22:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6386: Diff 9504.Jun 17 2019, 22:57
teamcity added a comment.Jun 18 2019, 03:02

Build Bitcoin-ABC / Master / Nightly Builds / Bitcoin-ABC IBD Diff Testing started.

teamcity added a comment.Jun 18 2019, 09:05

Build Bitcoin-ABC / Master / Nightly Builds / Bitcoin-ABC IBD Diff Testing failed.

jasonbcox updated this revision to Diff 9517.Jun 18 2019, 17:43

Fix SIGPIPE failure, but without ignoring other pipeline failures

teamcity added a comment.Jun 18 2019, 17:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox planned changes to this revision.Jun 18 2019, 17:43
teamcity added a comment.Jun 18 2019, 17:44

Build Bitcoin-ABC / Master / Nightly Builds / Bitcoin-ABC IBD Diff Testing started.

teamcity added a comment.Jun 18 2019, 17:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6390: Diff 9517.Jun 18 2019, 17:53
teamcity added a comment.Jun 19 2019, 00:36

Build Bitcoin-ABC / Master / Nightly Builds / Bitcoin-ABC IBD Diff Testing failed.

jasonbcox updated this revision to Diff 9543.Jun 19 2019, 20:56

Apparently tail has multiple failure modes for broken pipes, so trapping only catches one of them.
Using set +o pipefail instead.

teamcity added a comment.Jun 19 2019, 20:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox planned changes to this revision.Jun 19 2019, 20:57
teamcity added a comment.Jun 19 2019, 20:57

Build Bitcoin-ABC / Master / Nightly Builds / Bitcoin-ABC IBD Diff Testing started.

teamcity added a comment.Jun 19 2019, 21:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6409: Diff 9543.Jun 19 2019, 21:04
teamcity added a comment.Jun 20 2019, 03:39

Build Bitcoin-ABC / Master / Gitian Builds / Bitcoin-ABC IBD Diff Testing passed.

jasonbcox requested review of this revision.Jun 20 2019, 15:35
Fabien accepted this revision.Jun 24 2019, 09:39
This revision is now accepted and ready to land.Jun 24 2019, 09:39
Closed by commit rABC88a45c98694f: Replumb ibd.sh to prepare for better post-IBD checks (authored by jasonbcox). · Explain WhyJun 24 2019, 17:42
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC88a45c98694f: Replumb ibd.sh to prepare for better post-IBD checks.
jasonbcox added a commit: rSTAGING88a45c98694f: Replumb ibd.sh to prepare for better post-IBD checks.Sep 19 2019, 00:29

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
57 lines

Diff 9517

View Options

contrib/teamcity/ibd.sh

Loading...