Differential D3391

wallet: Add input bytes to CInputCoin
ClosedPublic
Actions

Authored by deadalnix on Jun 22 2019, 20:37.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGac9f7d12da63: wallet: Add input bytes to CInputCoin
rABCac9f7d12da63: wallet: Add input bytes to CInputCoin

Summary

With nInputBytes, coin selection can execute without a reference to the COutput

This is a partial backport of Core PR12257 : https://github.com/bitcoin/bitcoin/pull/12257/commits/65b3eda458221644616d0fdd6ba0fe01bdbce893

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

inputbyte

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6447
Build 10941: Bitcoin ABC Buildbot (legacy)
Build 10940: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 22 2019, 20:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 22 2019, 20:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6447: Diff 9594.Jun 22 2019, 20:44

deadalnix added a child revision: D3393: wallet: Add output grouping.Jun 22 2019, 21:31

Fabien accepted this revision.Jun 24 2019, 10:35

This revision is now accepted and ready to land.Jun 24 2019, 10:35

Closed by commit rABCac9f7d12da63: wallet: Add input bytes to CInputCoin (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by deadalnix). · Explain WhyJun 24 2019, 15:23

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCac9f7d12da63: wallet: Add input bytes to CInputCoin.

deadalnix added a commit: rSTAGINGac9f7d12da63: wallet: Add input bytes to CInputCoin.Sep 19 2019, 00:27

Revision Contents
Changeset List

Path

Size

src/

wallet/

coinselection.h

11 lines

wallet.h

4 lines

Diff 9594

View Options

src/wallet/coinselection.h