Page MenuHomePhabricator
Differential D3395

test: Add basic testing for wallet groups
ClosedPublic
Actions

Authored by deadalnix on Jun 22 2019, 21:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING4ba29712a331: test: Add basic testing for wallet groups
rABC4ba29712a331: test: Add basic testing for wallet groups
Summary

This is a partial backport of Core PR12257 : https://github.com/bitcoin/bitcoin/pull/12257/commits/0128121101fb3ee82f3abd3973a967a4226ffe0e

Depends on D3394

Also include the test for a later bugfix:

  • [qa] Add test for too-large wallet output groups

This is extracted from Core PR13805 : https://github.com/bitcoin/bitcoin/pull/13805/commits/a13647b8bd667ca58d8e82682c1d46555dce42c9

Test Plan
test/functional/test_runner.py wallet_groups

Diff Detail

Repository
rABC Bitcoin ABC
Branch
addbasictesting
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6477
Build 11001: Bitcoin ABC Buildbot (legacy)
Build 11000: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 22 2019, 21:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 22 2019, 21:53
teamcity added a comment.Jun 22 2019, 21:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 22 2019, 22:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6451: Diff 9598.Jun 22 2019, 22:05
Fabien mentioned this in D3392: Add -avoidpartialspends and m_avoid_partial_spends.Jun 24 2019, 10:45
Fabien requested changes to this revision.Jun 24 2019, 12:10
Fabien added a subscriber: Fabien.

Please fix the linter issues and update the timings.json file.

This revision now requires changes to proceed.Jun 24 2019, 12:10
deadalnix edited the summary of this revision. (Show Details)Jun 25 2019, 14:39
deadalnix updated this revision to Diff 9648.Jun 25 2019, 14:44

Add test case from PR13805 and addres various comments

teamcity added a comment.Jun 25 2019, 14:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6477: Diff 9648.Jun 25 2019, 14:51
teamcity added a comment.Jun 25 2019, 14:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien added inline comments.Jun 25 2019, 14:52
test/functional/wallet_groups.py
81

Nit: spaces arount the operator: "0" * 64

Fabien accepted this revision.Jun 25 2019, 15:02
This revision is now accepted and ready to land.Jun 25 2019, 15:02
Closed by commit rABC4ba29712a331: test: Add basic testing for wallet groups (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by deadalnix). · Explain WhyJun 25 2019, 15:06
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC4ba29712a331: test: Add basic testing for wallet groups.
deadalnix added a commit: rSTAGING4ba29712a331: test: Add basic testing for wallet groups.Sep 19 2019, 00:32

Revision Contents
Changeset List

PathSize
test/
functional/
100 lines

Diff 9648

View Options

test/functional/wallet_groups.py

Loading...