Page MenuHomePhabricator
Differential D3388

Backport last relevant bit of #11389
ClosedPublic
Actions

Authored by markblundeberg on Jun 22 2019, 05:32.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING3c7a9fb0d618: Backport last relevant bit of #11389
rABC3c7a9fb0d618: Backport last relevant bit of #11389
Summary

Most of #11389 was irrelevant except for D3366. This backports the only
other possibly relevant excerpt that may help to keep code in sync:
https://github.com/bitcoin/bitcoin/pull/11389/commits/d618458184742b15a7ab0349127ede7a2946a182

Test Plan

test_runner.py with ZMQ support

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6479
Build 11005: Bitcoin ABC Buildbot (legacy)
Build 11004: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 22 2019, 05:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 22 2019, 05:32
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 22 2019, 05:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 22 2019, 05:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B6444: Diff 9591!Jun 22 2019, 05:37
markblundeberg planned changes to this revision.Jun 22 2019, 11:55
Fabien added inline comments.Jun 24 2019, 07:10
test/functional/interface_zmq.py
10 ↗(On Diff #9591)

from test_framework.messages import CTransaction
That's the cause of your build failure.

16 ↗(On Diff #9591)

Move above the imports from test_framework

markblundeberg updated this revision to Diff 9657.Jun 25 2019, 16:26

tweak

teamcity added a comment.Jun 25 2019, 16:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a comment.Jun 25 2019, 16:27

(note: I don't have ZMQ installed locally so I am basically relying on CI for this testing :/)

teamcity added a comment.Jun 25 2019, 16:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6479: Diff 9657.Jun 25 2019, 16:35
deadalnix accepted this revision.Jun 25 2019, 16:36
This revision is now accepted and ready to land.Jun 25 2019, 16:36
Closed by commit rABC3c7a9fb0d618: Backport last relevant bit of #11389 (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 26 2019, 00:50
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC3c7a9fb0d618: Backport last relevant bit of #11389.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING3c7a9fb0d618: Backport last relevant bit of #11389.Sep 19 2019, 00:33

Revision Contents
Changeset List

PathSize
test/
functional/
7 lines

Diff 9657

View Options

test/functional/interface_zmq.py

Loading...