For some reason, InsecureRand32 was skipped and various other changes were not up to the orginal.
Details
Details
- Reviewers
jasonbcox Fabien - Group Reviewers
Restricted Project - Commits
- rSTAGING93e1fc4228a0: Handle various leftover from PR10321
rABC93e1fc4228a0: Handle various leftover from PR10321
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- pr10321
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 6513 Build 11073: Bitcoin ABC Buildbot (legacy) Build 11072: arc lint + arc unit
Event Timeline
src/test/coins_tests.cpp | ||
---|---|---|
169 ↗ | (On Diff #9761) | This either needs to be consistent throughout this file, or matching the original PR. imo InsecureRandBits(6) is easier to read |
311 ↗ | (On Diff #9761) | Original PR: InsecureRand32() & 0x3F |