Paths

Table of Contentst

Differential D3441

Handle various leftover from PR10321
ClosedPublic
Actions

Authored by deadalnix on Jun 27 2019, 17:28.

Tags

None

Subscribers

Details

Reviewers

jasonbcox
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING93e1fc4228a0: Handle various leftover from PR10321
rABC93e1fc4228a0: Handle various leftover from PR10321

Summary

For some reason, InsecureRand32 was skipped and various other changes were not up to the orginal.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr10321

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6517
Build 11081: Bitcoin ABC Buildbot (legacy)
Build 11080: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 27 2019, 17:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 27 2019, 17:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6513: Diff 9723.Jun 27 2019, 17:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix retitled this revision from Handle variosu leftover from PR10321 to Handle various leftover from PR10321.Jun 27 2019, 23:04

Revert prevector_tester ctor.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6517: Diff 9736.Jun 27 2019, 23:15

deadalnix added a child revision: D3450: Make unit tests use the insecure_rand_ctx exclusively.Jun 28 2019, 00:06

Rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6533: Diff 9761.Jun 28 2019, 14:12

jasonbcox requested changes to this revision.Jun 28 2019, 16:27

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/test/coins_tests.cpp
169 ↗	(On Diff #9761)	This either needs to be consistent throughout this file, or matching the original PR. Original PR uses `InsecureRandBits(6)` here, but see my other comment below how the opposite is true for a similar change. imo `InsecureRandBits(6)` is easier to read
311 ↗	(On Diff #9761)	Original PR: `InsecureRand32() & 0x3F`

This revision now requires changes to proceed.Jun 28 2019, 16:27

rebase and fix details to match the PR better

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6557: Diff 9804.Jun 29 2019, 23:50

Fabien accepted this revision.Jul 1 2019, 08:59

jasonbcox accepted this revision.Jul 1 2019, 21:22

This revision is now accepted and ready to land.Jul 1 2019, 21:22

Closed by commit rABC93e1fc4228a0: Handle various leftover from PR10321 (authored by deadalnix). · Explain WhyJul 1 2019, 22:15

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC93e1fc4228a0: Handle various leftover from PR10321.

deadalnix added a commit: rSTAGING93e1fc4228a0: Handle various leftover from PR10321.Sep 19 2019, 00:50

Revision Contents
Changeset List

Path

Size

src/

test/

coins_tests.cpp

22 lines

prevector_tests.cpp

12 lines

sigcache_tests.cpp

2 lines

sighash_tests.cpp

13 lines

2 lines

7 lines

wallet/

test/

wallet_crypto_tests.cpp

2 lines

Diff 9736

src/test/coins_tests.cpp

Loading...

src/test/prevector_tests.cpp

Loading...

src/test/sigcache_tests.cpp

Loading...

src/test/sighash_tests.cpp

Loading...

src/test/test_bitcoin.h

Loading...

src/test/util_tests.cpp

Loading...

src/wallet/test/wallet_crypto_tests.cpp

Loading...