Page MenuHomePhabricator
Differential D3441

Handle various leftover from PR10321
ClosedPublic
Actions

Authored by deadalnix on Jun 27 2019, 17:28.

Details

Reviewers
jasonbcox
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING93e1fc4228a0: Handle various leftover from PR10321
rABC93e1fc4228a0: Handle various leftover from PR10321
Summary

For some reason, InsecureRand32 was skipped and various other changes were not up to the orginal.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10321
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6533
Build 11113: Bitcoin ABC Buildbot (legacy)
Build 11112: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 27 2019, 17:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 27 2019, 17:28
teamcity added a comment.Jun 27 2019, 17:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6513: Diff 9723.Jun 27 2019, 17:39
teamcity added a comment.Jun 27 2019, 17:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix retitled this revision from Handle variosu leftover from PR10321 to Handle various leftover from PR10321.Jun 27 2019, 23:04
deadalnix updated this revision to Diff 9736.Jun 27 2019, 23:08

Revert prevector_tester ctor.

teamcity added a comment.Jun 27 2019, 23:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 27 2019, 23:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6517: Diff 9736.Jun 27 2019, 23:15
deadalnix added a child revision: D3450: Make unit tests use the insecure_rand_ctx exclusively.Jun 28 2019, 00:06
deadalnix updated this revision to Diff 9761.Jun 28 2019, 14:02

Rebase

teamcity added a comment.Jun 28 2019, 14:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 28 2019, 14:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6533: Diff 9761.Jun 28 2019, 14:12
jasonbcox requested changes to this revision.Jun 28 2019, 16:27
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/coins_tests.cpp
169

This either needs to be consistent throughout this file, or matching the original PR.
Original PR uses InsecureRandBits(6) here, but see my other comment below how the opposite is true for a similar change.

imo InsecureRandBits(6) is easier to read

311

Original PR: InsecureRand32() & 0x3F

This revision now requires changes to proceed.Jun 28 2019, 16:27
deadalnix updated this revision to Diff 9804.Jun 29 2019, 23:41

rebase and fix details to match the PR better

teamcity added a comment.Jun 29 2019, 23:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 29 2019, 23:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6557: Diff 9804.Jun 29 2019, 23:50
Fabien accepted this revision.Jul 1 2019, 08:59
jasonbcox accepted this revision.Jul 1 2019, 21:22
This revision is now accepted and ready to land.Jul 1 2019, 21:22
Closed by commit rABC93e1fc4228a0: Handle various leftover from PR10321 (authored by deadalnix). · Explain WhyJul 1 2019, 22:15
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC93e1fc4228a0: Handle various leftover from PR10321.
deadalnix added a commit: rSTAGING93e1fc4228a0: Handle various leftover from PR10321.Sep 19 2019, 00:50

Revision Contents
Changeset List

PathSize
src/
test/
22 lines
12 lines
13 lines
2 lines
7 lines
wallet/
test/
2 lines

Diff 9761

View Options

src/test/coins_tests.cpp

Loading...
View Options

src/test/prevector_tests.cpp

Loading...
View Options

src/test/sighash_tests.cpp

Loading...
View Options

src/test/test_bitcoin.h

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/wallet/test/wallet_crypto_tests.cpp

Loading...