Page MenuHomePhabricator
Differential D3461

Enable flake8 warnings for all currently non-violated rules
ClosedPublic
Actions

Authored by Fabien on Jun 28 2019, 15:03.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING8d33e81e7bf1: Enable flake8 warnings for all currently non-violated rules
rABC8d33e81e7bf1: Enable flake8 warnings for all currently non-violated rules
Summary

Also include an unrelated variable rename:
Fix accidental redefinition via list comprehension
to be in par with core as it is part of the PR.

I removed W504 as it conflicts with autopep8, and W605 as it throws a lot of warnings. They will be
fixed and added in follow-ups to not bloat this diff.

Backport of core PR12295
https://github.com/bitcoin/bitcoin/pull/12295/files

Test Plan
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12295
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6537
Build 11121: Bitcoin ABC Buildbot (legacy)
Build 11120: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 28 2019, 15:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 28 2019, 15:03
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 28 2019, 15:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien updated this revision to Diff 9769.Jun 28 2019, 15:05

Remove unrelated change

teamcity added a comment.Jun 28 2019, 15:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien edited the summary of this revision. (Show Details)Jun 28 2019, 15:09
Harbormaster completed remote builds in B6537: Diff 9768.Jun 28 2019, 15:10
teamcity added a comment.Jun 28 2019, 15:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

teamcity added a comment.Jun 28 2019, 15:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6538: Diff 9769.Jun 28 2019, 15:11
Fabien added a child revision: D3462: [LINTER] Enforce flake8 W605 warning.Jun 28 2019, 16:31
jasonbcox accepted this revision.Jun 28 2019, 16:33
This revision is now accepted and ready to land.Jun 28 2019, 16:33
Closed by commit rABC8d33e81e7bf1: Enable flake8 warnings for all currently non-violated rules (authored by Fabien). · Explain WhyJun 28 2019, 17:46
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC8d33e81e7bf1: Enable flake8 warnings for all currently non-violated rules.
Fabien added a commit: rSTAGING8d33e81e7bf1: Enable flake8 warnings for all currently non-violated rules.Sep 19 2019, 00:43

Revision Contents
Changeset List

PathSize
2 lines
contrib/
devtools/
4 lines
test/
functional/
4 lines

Diff 9768

View Options

.arclint

Loading...
View Options

contrib/devtools/copyright_header.py

Loading...
View Options

test/functional/rpc_fundrawtransaction.py

Loading...