Page MenuHomePhabricator
Differential D3462

[LINTER] Enforce flake8 W605 warning
ClosedPublic
Actions

Authored by Fabien on Jun 28 2019, 16:31.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING43b15a49cbf0: [LINTER] Enforce flake8 W605 warning
rABC43b15a49cbf0: [LINTER] Enforce flake8 W605 warning
Summary

This enforce the future-proof usage of r"string" strings.
https://lintlyci.github.io/Flake8Rules/rules/W605.html

Depends on D3461

Test Plan
arc lint --everything

Should exhibit no failure nor warning/exception:

PYTHONWARNINGS=default::DeprecationWarning ./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
linter_flake8_w504
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6543
Build 11133: Bitcoin ABC Buildbot (legacy)
Build 11132: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 28 2019, 16:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 28 2019, 16:31
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 28 2019, 16:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 28 2019, 16:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6541: Diff 9775.Jun 28 2019, 16:37
Fabien updated this revision to Diff 9784.Jun 28 2019, 17:47

Rebase

teamcity added a comment.Jun 28 2019, 17:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 28 2019, 17:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6543: Diff 9784.Jun 28 2019, 17:54
Fabien edited the test plan for this revision. (Show Details)Jun 28 2019, 21:39
jasonbcox accepted this revision.Jun 28 2019, 21:41
This revision is now accepted and ready to land.Jun 28 2019, 21:41
Fabien mentioned this in D3470: Add documentation on how to display python deprecation warnings.Jun 28 2019, 21:53
Closed by commit rABC43b15a49cbf0: [LINTER] Enforce flake8 W605 warning (authored by Fabien). · Explain WhyJun 28 2019, 21:55
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC43b15a49cbf0: [LINTER] Enforce flake8 W605 warning.
Fabien mentioned this in rABCaf6f0bc21780: Add documentation on how to display python deprecation warnings.Jul 1 2019, 12:42
Fabien added a commit: rSTAGING43b15a49cbf0: [LINTER] Enforce flake8 W605 warning.Sep 19 2019, 00:44
Fabien mentioned this in rSTAGINGaf6f0bc21780: Add documentation on how to display python deprecation warnings.Sep 19 2019, 00:47

Revision Contents
Changeset List

PathSize
2 lines
contrib/
devtools/
54 lines
2 lines
linearize/
4 lines
4 lines
test/
functional/
6 lines
6 lines
2 lines
6 lines
4 lines
6 lines
lint/
4 lines
2 lines

Diff 9784

View Options

.arclint

Loading...
View Options

contrib/devtools/copyright_header.py

Loading...
View Options

contrib/devtools/symbol-check.py

Loading...
View Options

contrib/linearize/linearize-data.py

Loading...
View Options

contrib/linearize/linearize-hashes.py

Loading...
View Options

test/functional/abc-cmdline.py

Loading...
View Options

test/functional/abc-rpc.py

Loading...
View Options

test/functional/feature_logging.py

Loading...
View Options

test/functional/feature_uacomment.py

Loading...
View Options

test/functional/test_runner.py

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...
View Options

test/lint/check-doc.py

Loading...
View Options

test/lint/lint-format-strings.py

Loading...