Page MenuHomePhabricator
Differential D3481

Merge #11083: Fix combinerawtransaction RPC help result section
ClosedPublic
Actions

Authored by markblundeberg on Jun 30 2019, 20:34.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGa9f8c7964807: Merge #11083: Fix combinerawtransaction RPC help result section
rABCa9f8c7964807: Merge #11083: Fix combinerawtransaction RPC help result section
Summary

PR11083 backport https://github.com/bitcoin/bitcoin/pull/11083/files
f9ca0fe Fix combinerawtransaction RPC help result section (Jonas Nick)

Pull request description:

Without this PR it looks like the RPC would return something like a dictionary. But it just returns the transaction in hex.
Test Plan

make check
read

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6565
Build 11177: Bitcoin ABC Buildbot (legacy)
Build 11176: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 30 2019, 20:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 30 2019, 20:34
teamcity added a comment.Jun 30 2019, 20:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6565: Diff 9812.Jun 30 2019, 20:41
teamcity added a comment.Jun 30 2019, 20:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Jun 30 2019, 20:45
This revision is now accepted and ready to land.Jun 30 2019, 20:45
Closed by commit rABCa9f8c7964807: Merge #11083: Fix combinerawtransaction RPC help result section (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 30 2019, 23:24
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCa9f8c7964807: Merge #11083: Fix combinerawtransaction RPC help result section.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGa9f8c7964807: Merge #11083: Fix combinerawtransaction RPC help result section.Sep 19 2019, 00:44

Revision Contents
Changeset List

PathSize
src/
rpc/
4 lines

Diff 9812

View Options

src/rpc/rawtransaction.cpp

Loading...