Merge #11094: Docs: Hash in ZMQ hash is raw bytes, not hex
ClosedPublic
Actions

Authored by markblundeberg on Jun 30 2019, 20:41.

Details

Reviewers

deadalnix
jasonbcox
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING4ab191e8f9d0: Merge #11094: Docs: Hash in ZMQ hash is raw bytes, not hex
rABC4ab191e8f9d0: Merge #11094: Docs: Hash in ZMQ hash is raw bytes, not hex

Summary

PR11094 backport https://github.com/bitcoin/bitcoin/pull/11094/files
06a3aec Docs: Hash in ZMQ hash is raw bytes, not hex (Karel Bílek)

Pull request description:

Transaction hex cannot be in hexadecimal, that would be 64 bytes. In reality it's just raw bytes.

Test Plan

read

Diff Detail

Repository

rABC Bitcoin ABC

Branch

patch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6566
Build 11179: Bitcoin ABC Buildbot (legacy)
Build 11178: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 30 2019, 20:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 30 2019, 20:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6566: Diff 9813.Jun 30 2019, 20:47

deadalnix accepted this revision.Jun 30 2019, 20:48

This revision is now accepted and ready to land.Jun 30 2019, 20:48

Closed by commit rABC4ab191e8f9d0: Merge #11094: Docs: Hash in ZMQ hash is raw bytes, not hex (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 30 2019, 23:25

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC4ab191e8f9d0: Merge #11094: Docs: Hash in ZMQ hash is raw bytes, not hex.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING4ab191e8f9d0: Merge #11094: Docs: Hash in ZMQ hash is raw bytes, not hex.Sep 19 2019, 00:45

Revision Contents
Changeset List

Path

Size

doc/

zmq.md

2 lines

Diff 9813

View Options

Merge #11094: Docs: Hash in ZMQ hash is raw bytes, not hexClosedPublicActions