Page MenuHomePhabricator
Feed Advanced Search

Mar 25 2022

kieran709 planned changes to D11265: [Cashtab-v2] Address linting errors throughout the app.
Mar 25 2022, 19:27
kieran709 requested review of D11265: [Cashtab-v2] Address linting errors throughout the app.
Mar 25 2022, 19:25
kieran709 accepted D11263: [Cashtab] Run tests in UTC timezone.
Mar 25 2022, 16:39
kieran709 accepted D11255: [Cashtab] Support migration to jest 27.
Mar 25 2022, 16:11
kieran709 requested review of D11262: [Cashtab-v2] Webpack 5 CSS patch: ant-descriptions-title.
Mar 25 2022, 15:53
kieran709 requested review of D11261: [Cashtab-v2] Token name input field css patch.
Mar 25 2022, 15:23

Mar 23 2022

kieran709 accepted D11254: [Cashtab] webpack upgrade p13.
Mar 23 2022, 23:49
kieran709 requested review of D11253: [Cashtab-v2] Fixed font color of alerts in Configure.js.
Mar 23 2022, 22:10
kieran709 closed D11252: [Cashtab-v2] Patch Send Confirmations text color in Configure.js.
Mar 23 2022, 21:59
kieran709 committed rABC9c428756c814: [Cashtab-v2] Patch Send Confirmations text color in Configure.js (authored by kieran709).
[Cashtab-v2] Patch Send Confirmations text color in Configure.js
Mar 23 2022, 21:59
kieran709 updated the summary of D11252: [Cashtab-v2] Patch Send Confirmations text color in Configure.js.
Mar 23 2022, 20:57
kieran709 requested review of D11252: [Cashtab-v2] Patch Send Confirmations text color in Configure.js.
Mar 23 2022, 20:57
kieran709 closed D11251: [Cashtab-v2] Fix Tx component width.
Mar 23 2022, 20:01
kieran709 committed rABC7fd452229753: [Cashtab-v2] Fix Tx component width (authored by kieran709).
[Cashtab-v2] Fix Tx component width
Mar 23 2022, 20:01
kieran709 requested review of D11251: [Cashtab-v2] Fix Tx component width.
Mar 23 2022, 19:57
kieran709 accepted D11250: [Cashtab] Webpack upgrade p10, first working version.
Mar 23 2022, 18:51
kieran709 accepted D11249: [Cashtab] Webpack upgrade part 9, fix import order.
Mar 23 2022, 18:29
kieran709 accepted D11248: [Cashtab] Webpack upgrade part 8, rework absolute imports.
Mar 23 2022, 17:54
kieran709 accepted D11247: [Cashtab] Webpack upgrade step 7, add scripts to package.json.
Mar 23 2022, 17:24
kieran709 accepted D11246: [Cashtab] Webpack upgrade part 6, feature freeze and source code copy.
Mar 23 2022, 17:17

Mar 22 2022

kieran709 closed D11235: [Cashtab] Make disabled send button more explicit.
Mar 22 2022, 20:26
kieran709 committed rABC057a20402da2: [Cashtab] Make disabled send button more explicit (authored by kieran709).
[Cashtab] Make disabled send button more explicit
Mar 22 2022, 20:26
kieran709 updated the diff for D11235: [Cashtab] Make disabled send button more explicit.

responding to review feedback & updating snapshots

Mar 22 2022, 19:47
kieran709 closed D11242: [Cashtab] Moved param alert above send button.
Mar 22 2022, 18:37
kieran709 committed rABC54ee1d8ff8d4: [Cashtab] Moved param alert above send button (authored by kieran709).
[Cashtab] Moved param alert above send button
Mar 22 2022, 18:37
kieran709 updated the diff for D11235: [Cashtab] Make disabled send button more explicit.

responding to review feedback

Mar 22 2022, 18:35
kieran709 requested review of D11242: [Cashtab] Moved param alert above send button.
Mar 22 2022, 15:32
kieran709 closed D11217: [Cashtab] Support param parsing in QR scanned addresses.
Mar 22 2022, 14:01
kieran709 committed rABC349c4d15015d: [Cashtab] Support param parsing in QR scanned addresses (authored by kieran709).
[Cashtab] Support param parsing in QR scanned addresses
Mar 22 2022, 14:01

Mar 21 2022

kieran709 updated the diff for D11235: [Cashtab] Make disabled send button more explicit.

updated snapshots

Mar 21 2022, 21:19
kieran709 requested review of D11235: [Cashtab] Make disabled send button more explicit.
Mar 21 2022, 21:18
kieran709 updated the diff for D11217: [Cashtab] Support param parsing in QR scanned addresses.

responding to review feedback

Mar 21 2022, 20:22

Mar 18 2022

kieran709 accepted D11232: [Cashtab] Ensure browserify is installed before extension build.
Mar 18 2022, 22:13
kieran709 accepted D11233: [Cashtab] Webpack upgrade, part 5.
Mar 18 2022, 22:06
kieran709 closed D11228: [Cashtab] Improve handling of priceApiError in Send.js.
Mar 18 2022, 21:35
kieran709 committed rABC82937429a224: [Cashtab] Improve handling of priceApiError in Send.js (authored by kieran709).
[Cashtab] Improve handling of priceApiError in Send.js
Mar 18 2022, 21:35
kieran709 accepted D11200: [Cashtab] Webpack upgrade part 4, dependencies.
Mar 18 2022, 21:29
kieran709 updated the diff for D11228: [Cashtab] Improve handling of priceApiError in Send.js.

responding to review feedback

Mar 18 2022, 20:23
kieran709 requested review of D11228: [Cashtab] Improve handling of priceApiError in Send.js.
Mar 18 2022, 16:10
kieran709 abandoned D11218: [Cashtab] Improve handling of price API error on send screen.
Mar 18 2022, 15:58

Mar 17 2022

kieran709 requested review of D11218: [Cashtab] Improve handling of price API error on send screen.
Mar 17 2022, 21:12
kieran709 requested review of D11217: [Cashtab] Support param parsing in QR scanned addresses.
Mar 17 2022, 18:48
kieran709 closed D11199: [Cashtab] BalanceHeaderFiat component handles null value for fiatPrice.
Mar 17 2022, 14:38
kieran709 committed rABC95587fe8f0d6: [Cashtab] BalanceHeaderFiat component handles null value for fiatPrice (authored by kieran709).
[Cashtab] BalanceHeaderFiat component handles null value for fiatPrice
Mar 17 2022, 14:38

Mar 16 2022

kieran709 requested review of D11199: [Cashtab] BalanceHeaderFiat component handles null value for fiatPrice.
Mar 16 2022, 19:56
kieran709 closed D11178: [Cashtab] Display fiat price in local currency.
Mar 16 2022, 18:48
kieran709 committed rABCb16ee3387a73: [Cashtab] Display fiat price in local currency (authored by kieran709).
[Cashtab] Display fiat price in local currency
Mar 16 2022, 18:48
kieran709 updated the diff for D11178: [Cashtab] Display fiat price in local currency.

Responding to review feedback

Mar 16 2022, 18:08
kieran709 accepted D11152: [Cashtab] Webpack upgrade part 3, polyfill support.
Mar 16 2022, 18:06
kieran709 requested changes to D11152: [Cashtab] Webpack upgrade part 3, polyfill support.

Change test plan to include npm install.

Mar 16 2022, 15:11
kieran709 updated the diff for D11178: [Cashtab] Display fiat price in local currency.

updated snapshots

Mar 16 2022, 15:02
kieran709 updated the diff for D11178: [Cashtab] Display fiat price in local currency.

Responding to review feedback

Mar 16 2022, 15:00

Mar 15 2022

kieran709 requested review of D11178: [Cashtab] Display fiat price in local currency.
Mar 15 2022, 21:44
kieran709 updated the summary of D11151: [Cashtab] Hide notification when switching apps/wallets.
Mar 15 2022, 19:17
kieran709 closed D11151: [Cashtab] Hide notification when switching apps/wallets.
Mar 15 2022, 19:06
kieran709 committed rABC5837ae3dd2ba: [Cashtab] Hide notification when switching apps/wallets (authored by kieran709).
[Cashtab] Hide notification when switching apps/wallets
Mar 15 2022, 19:06
kieran709 updated the summary of D11151: [Cashtab] Hide notification when switching apps/wallets.
Mar 15 2022, 19:05

Mar 14 2022

kieran709 closed D11165: [Cashtab] Remove unused styled import from TokenIcon.js.
Mar 14 2022, 22:47
kieran709 committed rABC042da95f2833: [Cashtab] Remove unused styled import from TokenIcon.js (authored by kieran709).
[Cashtab] Remove unused styled import from TokenIcon.js
Mar 14 2022, 22:47
kieran709 updated the diff for D11151: [Cashtab] Hide notification when switching apps/wallets.

Responding to review feedback.

Mar 14 2022, 22:45
kieran709 updated the diff for D11165: [Cashtab] Remove unused styled import from TokenIcon.js.

removed uncessary comment

Mar 14 2022, 20:57
kieran709 updated the diff for D11151: [Cashtab] Hide notification when switching apps/wallets.

added comment to force new test.

Mar 14 2022, 20:51
kieran709 updated the diff for D11165: [Cashtab] Remove unused styled import from TokenIcon.js.

added comment to force new test.

Mar 14 2022, 20:48
kieran709 accepted D11167: [Cashtab] Remove api call unit test.
Mar 14 2022, 20:16
kieran709 updated the diff for D11151: [Cashtab] Hide notification when switching apps/wallets.

Responding to review feedback.

Mar 14 2022, 20:15
kieran709 requested review of D11165: [Cashtab] Remove unused styled import from TokenIcon.js.
Mar 14 2022, 14:41
kieran709 abandoned D11148: [Cashtab] Removed unused import from TokenIcon.js.
Mar 14 2022, 14:41

Mar 9 2022

kieran709 accepted D11143: [Cashtab] Webpack upgrade part 2, ejecting create react app.
Mar 9 2022, 18:51
kieran709 planned changes to D11151: [Cashtab] Hide notification when switching apps/wallets.

Changes planned as outlined in summary.

Mar 9 2022, 17:03
kieran709 requested review of D11151: [Cashtab] Hide notification when switching apps/wallets.
Mar 9 2022, 17:02
kieran709 updated the diff for D11148: [Cashtab] Removed unused import from TokenIcon.js.

removed unnecessary comment

Mar 9 2022, 15:43
kieran709 updated the diff for D11148: [Cashtab] Removed unused import from TokenIcon.js.

Added comment to force rerun of tests.

Mar 9 2022, 15:41

Mar 8 2022

kieran709 requested review of D11148: [Cashtab] Removed unused import from TokenIcon.js.
Mar 8 2022, 15:19
kieran709 accepted D11124: [Cashtab] Correct proptypes validation for settings.
Mar 8 2022, 15:15

Mar 4 2022

kieran709 closed D11111: [Cashtab] Tx History collapse menu.
Mar 4 2022, 21:26
kieran709 committed rABC2524ad02e1b8: [Cashtab] Tx History collapse menu (authored by kieran709).
[Cashtab] Tx History collapse menu
Mar 4 2022, 21:26
kieran709 updated the diff for D11111: [Cashtab] Tx History collapse menu.

Removed commented code per review feedback.

Mar 4 2022, 20:58
kieran709 updated the diff for D11111: [Cashtab] Tx History collapse menu.

Replaced navigator copy to clipboard method with react-copy-to-clipboard. Removed hardcoded explorer url and replaced it with param in currency object.

Mar 4 2022, 19:06
kieran709 added a comment to D11111: [Cashtab] Tx History collapse menu.

Having looked into it further, I think it will be better to use react-copy-to-clipboard throughout the app as the navigator.clipboard.writeText() method will not work consistently across all browsers. This change will be reflected in my incoming revision.

Mar 4 2022, 18:10

Mar 3 2022

kieran709 accepted D11120: [Cashtab] Webpack upgrade part 1.
Mar 3 2022, 17:22

Mar 2 2022

kieran709 requested changes to D11120: [Cashtab] Webpack upgrade part 1.

Change test plan to include npm i.

Mar 2 2022, 23:47
kieran709 updated the diff for D11111: [Cashtab] Tx History collapse menu.

Updated snapshots

Mar 2 2022, 17:12
kieran709 closed D11115: [Cashtab] Remove comment code from useWallet.js.
Mar 2 2022, 16:39
kieran709 committed rABCc2e3feff4175: [Cashtab] Remove comment code from useWallet.js (authored by kieran709).
[Cashtab] Remove comment code from useWallet.js
Mar 2 2022, 16:39
kieran709 updated the diff for D11111: [Cashtab] Tx History collapse menu.

Responding to review feedback.

Mar 2 2022, 16:32

Feb 28 2022

kieran709 accepted D11114: [Cashtab] p8 of 8 for improved utxo mgmt.
Feb 28 2022, 21:24
kieran709 requested review of D11115: [Cashtab] Remove comment code from useWallet.js.
Feb 28 2022, 18:44
kieran709 updated the diff for D11111: [Cashtab] Tx History collapse menu.

Respond to review feedack, rebase & update snapshots.

Feb 28 2022, 17:32

Feb 25 2022

kieran709 requested review of D11111: [Cashtab] Tx History collapse menu.
Feb 25 2022, 22:13
kieran709 abandoned D11065: [Cashtab] Tx Hisotry collapse.
Feb 25 2022, 22:10
kieran709 updated the diff for D11065: [Cashtab] Tx Hisotry collapse.

Responding to review feedback.

Feb 25 2022, 20:36
kieran709 closed D11097: [Cashtab] Create TokenIcon Component.
Feb 25 2022, 16:35
kieran709 committed rABC4566bcd1dac4: [Cashtab] Create TokenIcon Component (authored by kieran709).
[Cashtab] Create TokenIcon Component
Feb 25 2022, 16:35
kieran709 updated the diff for D11065: [Cashtab] Tx Hisotry collapse.

Responding to review feedback.

Feb 25 2022, 16:30

Feb 23 2022

kieran709 closed D11096: [Cashtab] Do not open scanner on Send screen when value and address are prepopulated.
Feb 23 2022, 17:19
kieran709 committed rABC354df1e391d3: [Cashtab] Do not open scanner on Send screen when value and address are… (authored by kieran709).
[Cashtab] Do not open scanner on Send screen when value and address are…
Feb 23 2022, 17:19
kieran709 updated the diff for D11097: [Cashtab] Create TokenIcon Component.

Re-added TokenIconWrapper & updated snapshots.

Feb 23 2022, 00:26

Feb 22 2022

kieran709 updated the diff for D11097: [Cashtab] Create TokenIcon Component.

Upated snapshots.

Feb 22 2022, 23:01
kieran709 updated the diff for D11097: [Cashtab] Create TokenIcon Component.

Removed styled component TokenIconWrapper.

Feb 22 2022, 23:00
kieran709 updated the diff for D11097: [Cashtab] Create TokenIcon Component.

Increased token icon size on SendToken page to 64.

Feb 22 2022, 20:30