Page MenuHomePhabricator
Feed Advanced Search

Jan 4 2023

kieran709 added a comment to D12935: [Cashtab] Parse links in Cashtab Messages.

Having looked into it I am not certain I can parse relative links without a protocol unless at the very least, an external library is added. That said even the external libraries I have tested aren't perfect( lists of links separated by commas (ex. google.com, cashtab.com, yahoo.com becomes google.com, cashtab.com, yahoo.com,), if a url is provided that does not support https it cannot really be accounted for, plus some other nits). Let me know if you want to see a version that uses an external library, or if you have any advice for how to improve the functionality here I would appreciate it.

Jan 4 2023, 14:29

Dec 22 2022

kieran709 requested review of D12935: [Cashtab] Parse links in Cashtab Messages.
Dec 22 2022, 20:26

Dec 21 2022

kieran709 added a comment to D12931: [build-xec-apps][p1] Initial Commit.

Updated Summary per review feedback.

Dec 21 2022, 16:05
kieran709 updated the summary of D12931: [build-xec-apps][p1] Initial Commit.
Dec 21 2022, 16:03

Dec 20 2022

kieran709 updated the diff for D12933: [build-xec-apps][p3] Added chronik demo components.

removed unnecessary test prop from JSONPretty component

Dec 20 2022, 20:50
kieran709 requested review of D12933: [build-xec-apps][p3] Added chronik demo components.
Dec 20 2022, 20:42
kieran709 updated the summary of D12932: [build-xec-apps][p2] Added chronik logic.
Dec 20 2022, 19:42
kieran709 requested review of D12932: [build-xec-apps][p2] Added chronik logic.
Dec 20 2022, 19:41
kieran709 requested review of D12931: [build-xec-apps][p1] Initial Commit.
Dec 20 2022, 19:00
kieran709 abandoned D12930: [build-xec-apps][p1] Initial Commit.
Dec 20 2022, 18:52
kieran709 requested review of D12930: [build-xec-apps][p1] Initial Commit.
Dec 20 2022, 18:39
kieran709 abandoned D12927: [build-xec-apps][p1] initial commit.
Dec 20 2022, 18:30
kieran709 retitled D12927: [build-xec-apps][p1] initial commit from [build-xec-apps] initial commit to [build-xec-apps][p1] initial commit.
Dec 20 2022, 17:50
kieran709 requested review of D12927: [build-xec-apps][p1] initial commit.
Dec 20 2022, 15:27
kieran709 closed D12922: [Cashtab] Improve vertical centering of QRCode in Receive.js.
Dec 20 2022, 01:13
kieran709 committed rABC0fe80ccc4d0b: [Cashtab] Improve vertical centering of QRCode in Receive.js (authored by kieran709).
[Cashtab] Improve vertical centering of QRCode in Receive.js
Dec 20 2022, 01:13

Dec 19 2022

kieran709 requested review of D12922: [Cashtab] Improve vertical centering of QRCode in Receive.js.
Dec 19 2022, 21:27
kieran709 abandoned D12921: [Cashtab] Improve vertical centering of QR Code in Receive.js.
Dec 19 2022, 21:20
kieran709 updated the diff for D12921: [Cashtab] Improve vertical centering of QR Code in Receive.js.

updated snapshots

Dec 19 2022, 19:49
kieran709 updated the diff for D12921: [Cashtab] Improve vertical centering of QR Code in Receive.js.

removed test comment

Dec 19 2022, 19:44
kieran709 updated the diff for D12921: [Cashtab] Improve vertical centering of QR Code in Receive.js.

added test comment to trigger snapshot update & rebased to master

Dec 19 2022, 19:43
kieran709 requested review of D12921: [Cashtab] Improve vertical centering of QR Code in Receive.js.
Dec 19 2022, 19:17
kieran709 abandoned D12713: [Cashtab] Improve vertical centering of QRCode on Receive screen.
Dec 19 2022, 19:12

Dec 16 2022

kieran709 abandoned D12800: [xec-web-components][Pt3] Add changes from code-splitting branch.
Dec 16 2022, 01:14
kieran709 abandoned D12773: [xec-web-components][Pt2] Components lib: Use styled-components.
Dec 16 2022, 01:14
kieran709 abandoned D12772: [xec-web-components][Pt1] Create component lib: initial commit.
Dec 16 2022, 01:14
kieran709 abandoned D12872: [cashtab][test] Add Identity option to navMenu.
Dec 16 2022, 00:18
kieran709 added inline comments to D12772: [xec-web-components][Pt1] Create component lib: initial commit.
Dec 16 2022, 00:16

Dec 15 2022

kieran709 updated the diff for D12713: [Cashtab] Improve vertical centering of QRCode on Receive screen.

Responding to review feedback.

Dec 15 2022, 16:09

Dec 14 2022

kieran709 updated the diff for D12713: [Cashtab] Improve vertical centering of QRCode on Receive screen.

Reduced top and bottom padding of WalletInfoCtn by 10px.

Dec 14 2022, 16:55
kieran709 closed D12880: [Cashtab][extn] fix placement of popout button in extension.
Dec 14 2022, 16:36
kieran709 committed rABCddc832222723: [Cashtab][extn] fix placement of popout button in extension (authored by kieran709).
[Cashtab][extn] fix placement of popout button in extension
Dec 14 2022, 16:36

Dec 13 2022

kieran709 updated the diff for D12880: [Cashtab][extn] fix placement of popout button in extension.

Responding to review feedback

Dec 13 2022, 19:48
kieran709 requested review of D12880: [Cashtab][extn] fix placement of popout button in extension.
Dec 13 2022, 00:48
kieran709 abandoned D12879: [Cashtab][extn] Fix popout button placement.
Dec 13 2022, 00:47

Dec 12 2022

kieran709 requested review of D12879: [Cashtab][extn] Fix popout button placement.
Dec 12 2022, 23:43
kieran709 abandoned D12876: [Cashtab][extension] Fixed positioning of popout button on ext header.
Dec 12 2022, 23:13
kieran709 requested review of D12876: [Cashtab][extension] Fixed positioning of popout button on ext header.
Dec 12 2022, 22:18
kieran709 added a comment to D12773: [xec-web-components][Pt2] Components lib: Use styled-components.

In this diff, I am using the example provided here: https://github.com/HarveyD/react-component-library/compare/master...styled-components. As far as I can tell postcss doesn't run on styled components, though I may be able to find a plugin that will accomplish this if needed.

Dec 12 2022, 19:25
kieran709 updated the summary of D12773: [xec-web-components][Pt2] Components lib: Use styled-components.
Dec 12 2022, 18:54
kieran709 updated the diff for D12713: [Cashtab] Improve vertical centering of QRCode on Receive screen.

Responding to review feedback

Dec 12 2022, 18:52
kieran709 requested review of D12872: [cashtab][test] Add Identity option to navMenu.
Dec 12 2022, 17:00

Dec 9 2022

kieran709 accepted D12832: [Cashtab] [final countdown bch param p4 thru p7].
Dec 9 2022, 20:16
kieran709 added a comment to D12832: [Cashtab] [final countdown bch param p4 thru p7].

When sending an encrypted msg, the wallet that sent the encrypted msg repeatedly fires this warning. Tested on a wallet with no recent outgoing encrypted msgs and didn't get the error. I assume this isn't a big deal but wanted to flag it in case it is unexpected behavior.

Dec 9 2022, 18:55
kieran709 added inline comments to D12832: [Cashtab] [final countdown bch param p4 thru p7].
Dec 9 2022, 18:01

Dec 7 2022

kieran709 abandoned D12802: [Cashtab] Move appropriate deps to devDependencies.
Dec 7 2022, 22:12
kieran709 updated the diff for D12802: [Cashtab] Move appropriate deps to devDependencies.

Updated snapshots.

Dec 7 2022, 19:13
kieran709 requested review of D12802: [Cashtab] Move appropriate deps to devDependencies.
Dec 7 2022, 19:11
kieran709 requested review of D12800: [xec-web-components][Pt3] Add changes from code-splitting branch.
Dec 7 2022, 16:48
kieran709 abandoned D12712: [Cashtab] Move appropriate dependencies to devDependencies.
Dec 7 2022, 15:58

Dec 6 2022

kieran709 updated the diff for D12713: [Cashtab] Improve vertical centering of QRCode on Receive screen.

Responding to review feedback, media queries have been added to lessen the amount of margin on top of the QRCode component when the screen is between 1000px - 320px width.

Dec 6 2022, 22:19
kieran709 added a comment to D12712: [Cashtab] Move appropriate dependencies to devDependencies.

Wondering why the huksy pre-commit testing didn't catch the snapshot issue, any ideas?

Dec 6 2022, 21:24
kieran709 updated the diff for D12712: [Cashtab] Move appropriate dependencies to devDependencies.

Updated snapshots

Dec 6 2022, 21:14
kieran709 updated the diff for D12712: [Cashtab] Move appropriate dependencies to devDependencies.

Responding to review feedback

Dec 6 2022, 20:52
kieran709 closed D12735: [Cashtab] Add XBT to banned token ticker array.
Dec 6 2022, 06:53
kieran709 committed rABCa7240e984138: [Cashtab] Add XBT to banned token ticker array (authored by kieran709).
[Cashtab] Add XBT to banned token ticker array
Dec 6 2022, 06:53
kieran709 requested review of D12773: [xec-web-components][Pt2] Components lib: Use styled-components.
Dec 6 2022, 06:50
kieran709 requested review of D12772: [xec-web-components][Pt1] Create component lib: initial commit.
Dec 6 2022, 06:34
kieran709 requested review of D12771: [Cashtab] Update undefined checks.
Dec 6 2022, 06:15

Dec 3 2022

kieran709 closed D12738: [Cashtab] Patch addr validation error not displaying DestinationAddressMulti.
Dec 3 2022, 17:11
kieran709 committed rABCb8b5881ec704: [Cashtab] Patch addr validation error not displaying DestinationAddressMulti (authored by kieran709).
[Cashtab] Patch addr validation error not displaying DestinationAddressMulti
Dec 3 2022, 17:11
kieran709 updated the diff for D12738: [Cashtab] Patch addr validation error not displaying DestinationAddressMulti.

updated validValueString error msg to match validAddress

Dec 3 2022, 00:11
kieran709 updated the diff for D12738: [Cashtab] Patch addr validation error not displaying DestinationAddressMulti.

Responding to review feedback. Removed specific address from handleMultiAddressChange validAddress and validValueString error msgs. While this theoretically makes it harder to discern which address has an error, through testing I have learned that in its current state, the DestinationAddressMulti input only fires an error if the first address is invalid, meaning we aren't giving up too much. A task will be created to deal with this issue.

Dec 3 2022, 00:09

Dec 2 2022

kieran709 added a comment to D12738: [Cashtab] Patch addr validation error not displaying DestinationAddressMulti.

That makes sense. The way it works right now, the error will only fire if the first address is invalid. I would like to look into updating this to highlight the invalid address, regardless of position. I will create a task to look into it for a later diff.

Dec 2 2022, 23:50
kieran709 abandoned D12692: [xec-web-components][Pt1]Create component lib: Initial commit.
Dec 2 2022, 23:30
kieran709 abandoned D12740: [xec-web-components][Pt2] Update component generation scripts.
Dec 2 2022, 23:30
kieran709 updated the diff for D12740: [xec-web-components][Pt2] Update component generation scripts.

Removed test comment

Dec 2 2022, 23:08
kieran709 updated the diff for D12740: [xec-web-components][Pt2] Update component generation scripts.

ran arc diff instead of arc diff HEAD^

Dec 2 2022, 23:08
kieran709 reclaimed D12740: [xec-web-components][Pt2] Update component generation scripts.
Dec 2 2022, 23:07
kieran709 abandoned D12740: [xec-web-components][Pt2] Update component generation scripts.
Dec 2 2022, 23:05
kieran709 updated the test plan for D12740: [xec-web-components][Pt2] Update component generation scripts.
Dec 2 2022, 22:49
kieran709 requested review of D12740: [xec-web-components][Pt2] Update component generation scripts.
Dec 2 2022, 22:48
kieran709 added a reviewer for D12738: [Cashtab] Patch addr validation error not displaying DestinationAddressMulti: emack.
Dec 2 2022, 20:23
kieran709 requested review of D12738: [Cashtab] Patch addr validation error not displaying DestinationAddressMulti.
Dec 2 2022, 20:20
kieran709 requested review of D12735: [Cashtab] Add XBT to banned token ticker array.
Dec 2 2022, 17:46

Nov 30 2022

kieran709 updated the diff for D12692: [xec-web-components][Pt1]Create component lib: Initial commit.

Readme is not related to the xec-web-components library. A link to the project scaffolding will be added to the readme in a later update. Readme contains a typo which is causing build issues, which is why it is being removed in this diff, and not a later on in the stack.

Nov 30 2022, 22:22
kieran709 requested review of D12713: [Cashtab] Improve vertical centering of QRCode on Receive screen.
Nov 30 2022, 22:04
kieran709 requested review of D12712: [Cashtab] Move appropriate dependencies to devDependencies.
Nov 30 2022, 18:57

Nov 29 2022

kieran709 closed D12684: [Cashtab] Remove unused screenshots folder.
Nov 29 2022, 21:09
kieran709 committed rABC842e09e1e2d5: [Cashtab] Remove unused screenshots folder (authored by kieran709).
[Cashtab] Remove unused screenshots folder
Nov 29 2022, 21:09
kieran709 requested review of D12692: [xec-web-components][Pt1]Create component lib: Initial commit.
Nov 29 2022, 21:08
kieran709 abandoned D12686: [xec-web-components] Initial commit for xec-web-components library.
Nov 29 2022, 17:50
kieran709 accepted D12662: [Cashtab] [Simplify wallet structure p8] Remove debug logging.
Nov 29 2022, 16:06

Nov 28 2022

kieran709 accepted D12661: [Cashtab] [Simplify wallet structure p7] Patch bug in variable definition.
Nov 28 2022, 23:46
kieran709 accepted D12660: [Cashtab] [Simplify wallet structure p6] Ensure last final variable calcs match final variable names.
Nov 28 2022, 23:44
kieran709 accepted D12659: [Cashtab] [Simplify wallet structure p5] Remove function specific variable name change.
Nov 28 2022, 23:28
kieran709 accepted D12681: [Cashtab] [deprecate etoken addresses p4] Add temp info blurb to Receive.
Nov 28 2022, 23:17
kieran709 accepted D12680: [Cashtab] [deprecate etoken addresses p3] Remove address switch on receive screen.
Nov 28 2022, 23:15
kieran709 accepted D12679: [Cashtab] [deprecate etoken addresses p2] Remove type-specific address descriptors from placeholders and error msgs.
Nov 28 2022, 23:13
kieran709 accepted D12677: [Cashtab] [deprecate etoken addresses p1] Support token sends to ecash: addresses.
Nov 28 2022, 23:11
kieran709 added a reviewer for D12686: [xec-web-components] Initial commit for xec-web-components library: emack.
Nov 28 2022, 23:06
kieran709 updated the diff for D12686: [xec-web-components] Initial commit for xec-web-components library.

Removed content from README as it was irrelevant to the library.

Nov 28 2022, 22:47
kieran709 requested review of D12686: [xec-web-components] Initial commit for xec-web-components library.
Nov 28 2022, 22:44
kieran709 requested review of D12684: [Cashtab] Remove unused screenshots folder.
Nov 28 2022, 19:29
kieran709 abandoned D12683: [xec-web-components][TEST] xec-web-components initial commit.
Nov 28 2022, 19:13
kieran709 requested review of D12683: [xec-web-components][TEST] xec-web-components initial commit.
Nov 28 2022, 19:11
kieran709 closed D12640: [Cashtab] Patch overlapping text on amount input error Send.js.
Nov 28 2022, 19:03
kieran709 committed rABC5d37f08561d1: [Cashtab] Patch overlapping text on amount input error Send.js (authored by kieran709).
[Cashtab] Patch overlapping text on amount input error Send.js
Nov 28 2022, 19:03
kieran709 accepted D12641: [Cashtab] Remove unused imports from test file.
Nov 28 2022, 19:01
kieran709 accepted D12682: [Cashtab] Improve SEO.
Nov 28 2022, 18:10