Page MenuHomePhabricator
Feed Advanced Search

Tue, Nov 26

tobias_ruck updated the diff for D17193: [ecash-lib] Add support for LEGACY sighash.

rebase onto master

Tue, Nov 26, 13:42
tobias_ruck added inline comments to D17192: [Cashtab] Support ALP tokens.
Tue, Nov 26, 13:39
tobias_ruck accepted D17192: [Cashtab] Support ALP tokens.
Tue, Nov 26, 13:34

Mon, Nov 25

tobias_ruck retitled D17201: [Chronik] Take lock when accessing ActiveTip in chronikbridge_tests from take lock when accessing ActiveTip in chronikbridge_tests to [Chronik] Take lock when accessing ActiveTip in chronikbridge_tests.
Mon, Nov 25, 23:31
tobias_ruck accepted D17201: [Chronik] Take lock when accessing ActiveTip in chronikbridge_tests.
Mon, Nov 25, 23:31
teamcity awarded D17199: [guix] Update guix version so it supports FHS for MacOS a Haypence token.
Mon, Nov 25, 12:07
tobias_ruck added a comment to D17199: [guix] Update guix version so it supports FHS for MacOS.

@bot guix-osx

Mon, Nov 25, 12:07
tobias_ruck requested review of D17199: [guix] Update guix version so it supports FHS for MacOS.
Mon, Nov 25, 12:07
tobias_ruck requested changes to D17192: [Cashtab] Support ALP tokens.
Mon, Nov 25, 11:52
tobias_ruck accepted D17167: [chronik] updated dependencies - Cargo.lock.
Mon, Nov 25, 11:14
tobias_ruck accepted D17197: added Cargo.lock & Cargo.toml to runOnDiffRegex when chronik/ is mentioned.
Mon, Nov 25, 01:58
tobias_ruck accepted D17194: [chronik-client] Update GenesisInfo to return hex string for data key of ALP tokens.
Mon, Nov 25, 01:54
teamcity awarded D17198: [Chronik] Fix OSX build a Piece of Eight token.
Mon, Nov 25, 01:52
tobias_ruck requested changes to D17194: [chronik-client] Update GenesisInfo to return hex string for data key of ALP tokens.
Mon, Nov 25, 01:00

Sun, Nov 24

teamcity awarded D17198: [Chronik] Fix OSX build a Haypence token.
Sun, Nov 24, 22:59
tobias_ruck added a comment to D17197: added Cargo.lock & Cargo.toml to runOnDiffRegex when chronik/ is mentioned.

@bot build-chronik build-chronik-plugins ecash-lib-integration-tests chronik-client-integration-tests

Sun, Nov 24, 22:26
tobias_ruck requested changes to D17194: [chronik-client] Update GenesisInfo to return hex string for data key of ALP tokens.
Sun, Nov 24, 22:25

Sat, Nov 23

tobias_ruck updated the diff for D17193: [ecash-lib] Add support for LEGACY sighash.

fix tests

Sat, Nov 23, 19:53
tobias_ruck updated the test plan for D17193: [ecash-lib] Add support for LEGACY sighash.
Sat, Nov 23, 18:54
tobias_ruck updated the summary of D17193: [ecash-lib] Add support for LEGACY sighash.
Sat, Nov 23, 18:53
tobias_ruck requested review of D17193: [ecash-lib] Add support for LEGACY sighash.
Sat, Nov 23, 18:50

Thu, Nov 21

tobias_ruck closed D17179: [guix] Use CMake's PROJECT_NAME for source package.
Thu, Nov 21, 20:37
tobias_ruck committed rABC453ab41b380b: [guix] Use CMake's PROJECT_NAME for source package (authored by tobias_ruck).
[guix] Use CMake's PROJECT_NAME for source package
Thu, Nov 21, 20:37
teamcity awarded D17179: [guix] Use CMake's PROJECT_NAME for source package a Like token.
Thu, Nov 21, 18:08
tobias_ruck added a comment to D17179: [guix] Use CMake's PROJECT_NAME for source package.

@bot guix-linux

Thu, Nov 21, 18:08
tobias_ruck updated the diff for D17179: [guix] Use CMake's PROJECT_NAME for source package.

remove unrelated changes

Thu, Nov 21, 18:08
tobias_ruck planned changes to D17179: [guix] Use CMake's PROJECT_NAME for source package.
Thu, Nov 21, 18:05
tobias_ruck published D17179: [guix] Use CMake's PROJECT_NAME for source package for review.
Thu, Nov 21, 18:04
tobias_ruck closed D17178: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.
Thu, Nov 21, 17:10
tobias_ruck committed rABCbc5c8fabb06c: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt (authored by tobias_ruck).
[Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt
Thu, Nov 21, 17:10
teamcity awarded D17179: [guix] Use CMake's PROJECT_NAME for source package a Mountain of Wealth token.
Thu, Nov 21, 16:53
teamcity awarded D17179: [guix] Use CMake's PROJECT_NAME for source package a Doubloon token.
Thu, Nov 21, 15:24
teamcity awarded D17179: [guix] Use CMake's PROJECT_NAME for source package a Piece of Eight token.
Thu, Nov 21, 14:58
teamcity awarded D17179: [guix] Use CMake's PROJECT_NAME for source package a Haypence token.
Thu, Nov 21, 14:51
teamcity awarded D17178: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt a Haypence token.
Thu, Nov 21, 13:53
tobias_ruck retitled D17178: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt from [Cmake] Add ROOT_PROJECT_NAME, use in src/config/CMakeLists.txt to [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.
Thu, Nov 21, 13:47
tobias_ruck updated the diff for D17178: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.

remove unrelated changes

Thu, Nov 21, 13:41
tobias_ruck updated the diff for D17178: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.

we already have CMAKE_PROJECT_NAME, use that instead of making our own

Thu, Nov 21, 13:40
tobias_ruck requested review of D17178: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.
Thu, Nov 21, 13:36

Wed, Nov 20

tobias_ruck added a comment to D17167: [chronik] updated dependencies - Cargo.lock.

@bot build-chronik-plugins

Wed, Nov 20, 12:50
tobias_ruck requested changes to D17167: [chronik] updated dependencies - Cargo.lock.

the title is wrong (the file was already there) and the test plan too (missing -)

Wed, Nov 20, 12:49
tobias_ruck accepted D17155: [CHRONIK] add is_final to tx struct in util.rs.
Wed, Nov 20, 11:43

Tue, Nov 19

tobias_ruck requested changes to D17155: [CHRONIK] add is_final to tx struct in util.rs.
Tue, Nov 19, 22:12

Nov 9 2024

tobias_ruck accepted D17043: [chronik] implement scripthash type for utxos endpoints.
Nov 9 2024, 17:26
tobias_ruck accepted D17037: [chronik] index scripts by scripthashes in the mempool.

beautifully written!

Nov 9 2024, 17:16

Nov 8 2024

tobias_ruck added inline comments to D17043: [chronik] implement scripthash type for utxos endpoints.
Nov 8 2024, 13:37

Nov 5 2024

teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Nov 5 2024, 10:01
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Love token.
Nov 5 2024, 09:24
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Nov 5 2024, 08:58
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Love token.
Nov 5 2024, 08:16

Nov 4 2024

tobias_ruck added inline comments to D17037: [chronik] index scripts by scripthashes in the mempool.
Nov 4 2024, 12:45

Nov 2 2024

tobias_ruck added inline comments to D17046: [new lokad] Add spec for onchain trollbox for tokens.
Nov 2 2024, 08:18
tobias_ruck accepted D17046: [new lokad] Add spec for onchain trollbox for tokens.
Nov 2 2024, 05:05

Nov 1 2024

tobias_ruck added inline comments to D17037: [chronik] index scripts by scripthashes in the mempool.
Nov 1 2024, 19:36
tobias_ruck added inline comments to D17037: [chronik] index scripts by scripthashes in the mempool.
Nov 1 2024, 19:34
tobias_ruck requested changes to D17037: [chronik] index scripts by scripthashes in the mempool.
Nov 1 2024, 19:31
tobias_ruck added inline comments to D16937: [chronik] add scripthash option to the various script endpoints.
Nov 1 2024, 19:28
tobias_ruck accepted D16937: [chronik] add scripthash option to the various script endpoints.

One nit

Nov 1 2024, 19:27
tobias_ruck accepted D16944: [ecash-agora] Add validation to _acceptTxBuilder to prevent creation of unspendable offers.

Otherwise lgtm

Nov 1 2024, 19:19
tobias_ruck requested changes to D17046: [new lokad] Add spec for onchain trollbox for tokens.

Otherwise seems good to go, the timeFirstSeen seems fine.

Nov 1 2024, 17:42

Oct 31 2024

tobias_ruck requested changes to D17046: [new lokad] Add spec for onchain trollbox for tokens.
Oct 31 2024, 07:56
tobias_ruck added a comment to D17046: [new lokad] Add spec for onchain trollbox for tokens.

We might also want to use Shammah's CashWeb, which is much more generic and powerful, but also creates much less data on-chain:

Oct 31 2024, 07:56

Oct 30 2024

tobias_ruck requested changes to D17037: [chronik] index scripts by scripthashes in the mempool.
Oct 30 2024, 17:16
tobias_ruck requested changes to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 30 2024, 16:39
tobias_ruck requested changes to D16944: [ecash-agora] Add validation to _acceptTxBuilder to prevent creation of unspendable offers.
Oct 30 2024, 16:29
tobias_ruck requested changes to D17046: [new lokad] Add spec for onchain trollbox for tokens.
Oct 30 2024, 16:19

Oct 29 2024

tobias_ruck requested changes to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 29 2024, 11:30

Oct 26 2024

tobias_ruck requested changes to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 26 2024, 11:59

Oct 25 2024

tobias_ruck published D17000: [64-bit ints] Move `{Add,Sub}Int63Overflow(Emulated)` impl to cpp file for review.
Oct 25 2024, 08:55
tobias_ruck updated the summary of D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.
Oct 25 2024, 08:45
tobias_ruck updated the diff for D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.

remove getint32, change ScriptNum10::getint instead to support int64_t

Oct 25 2024, 08:42
tobias_ruck accepted D16827: [chronik] store a scripthash -> script index.

One comment nit

Oct 25 2024, 08:16

Oct 24 2024

tobias_ruck requested review of D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.
Oct 24 2024, 23:57
tobias_ruck accepted D16990: [ecash-herald] Parse token actions in daily summary msgs.
Oct 24 2024, 23:52
tobias_ruck accepted D16991: [Cashtab] Patch displayed spot prices for agora offers.
Oct 24 2024, 23:40
tobias_ruck accepted D16995: [ecash-agora] Improve approximation for USD-esque tokens.

Note: you can remove the note or un-bold it and move it to the bottom

Oct 24 2024, 23:21
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Oct 24 2024, 22:16
tobias_ruck requested changes to D16827: [chronik] store a scripthash -> script index.
Oct 24 2024, 19:27
tobias_ruck closed D16981: [CI] Update build-configurations with secp256k1 dependencies.
Oct 24 2024, 14:17
tobias_ruck committed rABC218edc02974a: [CI] Update build-configurations with secp256k1 dependencies (authored by tobias_ruck).
[CI] Update build-configurations with secp256k1 dependencies
Oct 24 2024, 14:17
tobias_ruck abandoned D16907: [ecash-lib] Add `rust-secp256k1`, use in `ecash-lib-wasm`.
Oct 24 2024, 13:17
tobias_ruck requested changes to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 24 2024, 12:24
tobias_ruck closed D16982: [Iguana] Display empty stack items as `""`.
Oct 24 2024, 12:10
tobias_ruck committed rABCde1c383640b3: [Iguana] Display empty stack items as `""` (authored by tobias_ruck).
[Iguana] Display empty stack items as `""`
Oct 24 2024, 12:09
tobias_ruck requested review of D16982: [Iguana] Display empty stack items as `""`.
Oct 24 2024, 10:07
tobias_ruck closed D16980: [linter] Fix shebang lint false positive.
Oct 24 2024, 09:34
tobias_ruck committed rABCcabdfe09fbe5: [linter] Fix shebang lint false positive (authored by tobias_ruck).
[linter] Fix shebang lint false positive
Oct 24 2024, 09:34
tobias_ruck requested changes to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 24 2024, 09:28
tobias_ruck requested changes to D16827: [chronik] store a scripthash -> script index.
Oct 24 2024, 09:14
tobias_ruck added inline comments to D16827: [chronik] store a scripthash -> script index.
Oct 24 2024, 09:14
tobias_ruck requested review of D16981: [CI] Update build-configurations with secp256k1 dependencies.
Oct 24 2024, 09:05
tobias_ruck requested review of D16980: [linter] Fix shebang lint false positive.
Oct 24 2024, 09:04
tobias_ruck closed D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.
Oct 24 2024, 08:23
tobias_ruck committed rABCbeb30ceabc8b: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm` (authored by tobias_ruck).
[ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`
Oct 24 2024, 08:23
tobias_ruck added a comment to D16827: [chronik] store a scripthash -> script index.

It seems like you're not indexing the mempool for scripthash yet, will this be in another diff? If so, add it to the summary. Otherwise I think it's fine to keep it in this diff, it's just a relatively simple HashMap.

Oct 24 2024, 08:20
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Love token.
Oct 24 2024, 08:09
tobias_ruck updated the diff for D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.

fix is_empty

Oct 24 2024, 07:33
tobias_ruck updated the diff for D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.

uncomment secp256k1_sys test

Oct 24 2024, 07:31

Oct 23 2024

tobias_ruck updated the diff for D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.

fix one usage of PublicKey

Oct 23 2024, 23:42
tobias_ruck added inline comments to D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.
Oct 23 2024, 23:12