Page MenuHomePhabricator
Feed Advanced Search

Sep 15 2025

PiRK updated the summary of D18624: qa: Wait for txindex to avoid race condition.
Sep 15 2025, 11:33
PiRK requested review of D18625: test: feature_init, only init what's needed per perturbation/deletion round.
Sep 15 2025, 11:32
PiRK updated the summary of D18624: qa: Wait for txindex to avoid race condition.
Sep 15 2025, 11:29
PiRK requested review of D18624: qa: Wait for txindex to avoid race condition.
Sep 15 2025, 11:28
PiRK added inline comments to D18623: qa: Add missing coverage of corrupt indexes.
Sep 15 2025, 11:27
PiRK requested review of D18623: qa: Add missing coverage of corrupt indexes.
Sep 15 2025, 11:26
PiRK requested review of D18622: init: abort loading of blockindex in case of missing height..
Sep 15 2025, 09:57
PiRK closed D18612: test: move logic error test to the end of the suite.
Sep 15 2025, 08:34
PiRK committed rABC5ab630464dfc: test: move logic error test to the end of the suite (authored by PiRK).
test: move logic error test to the end of the suite
Sep 15 2025, 08:34
PiRK closed D18611: test: Use std::unique_ptr over manual delete in coins_tests.
Sep 15 2025, 08:34
PiRK committed rABCe1f6c05f8638: test: Use std::unique_ptr over manual delete in coins_tests (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
test: Use std::unique_ptr over manual delete in coins_tests
Sep 15 2025, 08:34
PiRK updated the diff for D18620: Add linked-list test to CCoinsViewCache::SanityCheck.

braces on single line if

Sep 15 2025, 07:55
PiRK updated the diff for D18619: coins: move Sync logic to CoinsViewCacheCursor.

rebase, remove maybe_unused tags

Sep 15 2025, 07:54
PiRK updated the diff for D18618: coins: pass linked list of flagged entries to BatchWrite.

suppress clang-tidy warning about unused attrs (we use them in the next commit, temporarily removing them would cause multiple lines to be changed twice in two commitss)

Sep 15 2025, 07:53
PiRK planned changes to D18620: Add linked-list test to CCoinsViewCache::SanityCheck.
Sep 15 2025, 06:39
PiRK requested review of D18621: validation: don't erase coins cache on prune flushes.
Sep 15 2025, 06:38
PiRK requested review of D18620: Add linked-list test to CCoinsViewCache::SanityCheck.
Sep 15 2025, 06:32
PiRK requested review of D18619: coins: move Sync logic to CoinsViewCacheCursor.
Sep 15 2025, 06:30
PiRK updated the test plan for D18618: coins: pass linked list of flagged entries to BatchWrite.
Sep 15 2025, 06:27
PiRK requested review of D18618: coins: pass linked list of flagged entries to BatchWrite.
Sep 15 2025, 06:26
PiRK added inline comments to D18617: coins: track flagged cache entries in linked list.
Sep 15 2025, 06:25
PiRK requested review of D18617: coins: track flagged cache entries in linked list.
Sep 15 2025, 06:24
PiRK requested review of D18616: coins: call ClearFlags in CCoinsCacheEntry destructor.
Sep 15 2025, 06:20
PiRK requested review of D18615: refactor: require self and sentinel parameters for AddFlags.
Sep 15 2025, 06:18
PiRK requested review of D18614: refactor: add CoinsCachePair alias.
Sep 15 2025, 06:17

Sep 14 2025

PiRK accepted D18610: [proof-manager-cli] Add a CLI tool for stakes, proofs and delegation management.
Sep 14 2025, 12:34

Sep 12 2025

PiRK requested review of D18612: test: move logic error test to the end of the suite.
Sep 12 2025, 19:25
PiRK requested review of D18611: test: Use std::unique_ptr over manual delete in coins_tests.
Sep 12 2025, 19:24
PiRK closed D18605: refactor: disallow setting flags in CCoinsCacheEntry constructors.
Sep 12 2025, 19:21
PiRK committed rABC94b9239470da: refactor: disallow setting flags in CCoinsCacheEntry constructors (authored by Andrew Toth <andrewstoth@gmail.com>).
refactor: disallow setting flags in CCoinsCacheEntry constructors
Sep 12 2025, 19:21
PiRK closed D18604: refactor: encapsulate CCoinsCacheEntry flags access.
Sep 12 2025, 19:21
PiRK committed rABC291722dd5877: refactor: encapsulate CCoinsCacheEntry flags access (authored by Andrew Toth <andrewstoth@gmail.com>).
refactor: encapsulate CCoinsCacheEntry flags access
Sep 12 2025, 19:21

Sep 11 2025

PiRK updated the diff for D18605: refactor: disallow setting flags in CCoinsCacheEntry constructors.

rebase

Sep 11 2025, 19:00
PiRK updated the diff for D18604: refactor: encapsulate CCoinsCacheEntry flags access.

fix var shadowing

Sep 11 2025, 18:59
PiRK abandoned D18606: refactor: move flags to private and rename to m_flags.

suqashed with D18605

Sep 11 2025, 18:56
PiRK accepted D18602: [avalanche-lib-wasm] Introduce a new library for managing stakes, proofs and delegations.
Sep 11 2025, 18:37
PiRK updated the diff for D18605: refactor: disallow setting flags in CCoinsCacheEntry constructors.

suqash with D18606 to avoid temporary variable shadowing (renaming flags -> m_flags fixes this)

Sep 11 2025, 18:32
PiRK planned changes to D18604: refactor: encapsulate CCoinsCacheEntry flags access.

fix some intermediate var shadowing

Sep 11 2025, 16:05
PiRK requested review of D18606: refactor: move flags to private and rename to m_flags.
Sep 11 2025, 16:04
PiRK updated the diff for D18605: refactor: disallow setting flags in CCoinsCacheEntry constructors.

explicit

Sep 11 2025, 16:02
PiRK requested review of D18605: refactor: disallow setting flags in CCoinsCacheEntry constructors.
Sep 11 2025, 16:00
PiRK requested review of D18604: refactor: encapsulate CCoinsCacheEntry flags access.
Sep 11 2025, 15:59
PiRK added inline comments to D18602: [avalanche-lib-wasm] Introduce a new library for managing stakes, proofs and delegations.
Sep 11 2025, 15:27
PiRK closed D18599: index: don't commit state in BaseIndex::Rewind.
Sep 11 2025, 09:16
PiRK committed rABCf4bf299b8c03: index: don't commit state in BaseIndex::Rewind (authored by Martin Zumsande <mzumsande@gmail.com>).
index: don't commit state in BaseIndex::Rewind
Sep 11 2025, 09:16
PiRK committed rABC0641089bac14: refactor: index: use `AbortNode` in fatal error helper (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
refactor: index: use `AbortNode` in fatal error helper
Sep 11 2025, 09:16
PiRK closed D18597: refactor: index: use `AbortNode` in fatal error helper.
Sep 11 2025, 09:16
PiRK closed D18598: Return EXIT_FAILURE on post-init fatal errors.
Sep 11 2025, 09:16
PiRK committed rABC82348583961e: Return EXIT_FAILURE on post-init fatal errors (authored by furszy <matiasfurszyfer@protonmail.com>).
Return EXIT_FAILURE on post-init fatal errors
Sep 11 2025, 09:16
PiRK closed D18596: move ThreadImport ABC error to use AbortNode.
Sep 11 2025, 09:16
PiRK committed rABC663eb16ca700: move ThreadImport ABC error to use AbortNode (authored by furszy <matiasfurszyfer@protonmail.com>).
move ThreadImport ABC error to use AbortNode
Sep 11 2025, 09:16

Sep 10 2025

PiRK closed D18601: test: disable unit tests that are UB before C++20.
Sep 10 2025, 19:30
PiRK committed rABCae729760194a: test: disable unit tests that are UB before C++20 (authored by PiRK).
test: disable unit tests that are UB before C++20
Sep 10 2025, 19:30
teamcity awarded D18601: test: disable unit tests that are UB before C++20 a Haypence token.
Sep 10 2025, 19:00
PiRK retitled D18601: test: disable unit tests that are UB before C++20 from test: disable unit tests that are UB in C++17 to test: disable unit tests that are UB before C++20.
Sep 10 2025, 18:49
PiRK updated the summary of D18601: test: disable unit tests that are UB before C++20.
Sep 10 2025, 18:49
PiRK requested review of D18601: test: disable unit tests that are UB before C++20.
Sep 10 2025, 18:49
PiRK updated the summary of D18599: index: don't commit state in BaseIndex::Rewind.
Sep 10 2025, 16:04
PiRK requested review of D18599: index: don't commit state in BaseIndex::Rewind.
Sep 10 2025, 16:02
PiRK added a comment to D18598: Return EXIT_FAILURE on post-init fatal errors.

There is one more commit in core#27708 that cannot be backported yet, because of strong dependency on multiprocess/IPC backports. AFAICT it is a pure refactor with no behavior change, so not worth grabbing partially with workarounds that will make the multiprocess backports more confusing, better to get that one in the right order :
https://github.com/bitcoin/bitcoin/pull/27708/commits/61c569ab6069d04079a0831468eb713983919636

Sep 10 2025, 16:02
PiRK requested review of D18598: Return EXIT_FAILURE on post-init fatal errors.
Sep 10 2025, 15:58
PiRK requested review of D18597: refactor: index: use `AbortNode` in fatal error helper.
Sep 10 2025, 15:55
PiRK requested review of D18596: move ThreadImport ABC error to use AbortNode.
Sep 10 2025, 15:55
PiRK closed D18584: init: Use size_t consistently for cache sizes.
Sep 10 2025, 14:59
PiRK closed D18583: kernel: Move default cache constants to caches.
Sep 10 2025, 14:59
PiRK committed rABC5d40e193857d: kernel: Move default cache constants to caches (authored by TheCharlatan <seb.kung@gmail.com>).
kernel: Move default cache constants to caches
Sep 10 2025, 14:59
PiRK committed rABC6016718c9217: init: Use size_t consistently for cache sizes (authored by TheCharlatan <seb.kung@gmail.com>).
init: Use size_t consistently for cache sizes
Sep 10 2025, 14:59
PiRK closed D18582: kernel: Move non-kernel db cache size constants.
Sep 10 2025, 14:59
PiRK committed rABC9def493456af: kernel: Move kernel-specific cache size options to kernel (authored by TheCharlatan <seb.kung@gmail.com>).
kernel: Move kernel-specific cache size options to kernel
Sep 10 2025, 14:58
PiRK committed rABCe43334d98b7c: kernel: Move non-kernel db cache size constants (authored by TheCharlatan <seb.kung@gmail.com>).
kernel: Move non-kernel db cache size constants
Sep 10 2025, 14:58
PiRK closed D18581: kernel: Move kernel-specific cache size options to kernel.
Sep 10 2025, 14:58
PiRK committed rABC3577a712c85d: util: Add integer left shift helpers (authored by TheCharlatan <seb.kung@gmail.com>).
util: Add integer left shift helpers
Sep 10 2025, 14:58
PiRK closed D18579: [refactor] init: Simplify coinsdb cache calculation.
Sep 10 2025, 14:58
PiRK closed D18580: util: Add integer left shift helpers.
Sep 10 2025, 14:58
PiRK committed rABC9d4cbdd3a5f5: [refactor] init: Simplify coinsdb cache calculation (authored by TheCharlatan <seb.kung@gmail.com>).
[refactor] init: Simplify coinsdb cache calculation
Sep 10 2025, 14:58
PiRK committed rABCae13ae5d5dc7: doc: Correct docstring describing max block tree db cache (authored by TheCharlatan <seb.kung@gmail.com>).
doc: Correct docstring describing max block tree db cache
Sep 10 2025, 14:58
PiRK closed D18578: doc: Correct docstring describing max block tree db cache.
Sep 10 2025, 14:58
PiRK accepted D18593: [avalanche] Fix the getavalancheinfo status when the local proof is avalanche invalidated.
Sep 10 2025, 10:12
PiRK updated the diff for D18584: init: Use size_t consistently for cache sizes.

rebase, remove now useless cstdint in caches.h, remove unneeded other include (bad rebase conflict resolution)

Sep 10 2025, 10:07
PiRK updated the diff for D18583: kernel: Move default cache constants to caches.

rebase

Sep 10 2025, 10:04
PiRK updated the diff for D18582: kernel: Move non-kernel db cache size constants.

keep the cstdint header for now, it will be used in D18583 and removed in D18584

Sep 10 2025, 10:04
PiRK updated the diff for D18584: init: Use size_t consistently for cache sizes.

rebase

Sep 10 2025, 06:32
PiRK updated the diff for D18583: kernel: Move default cache constants to caches.

rebase

Sep 10 2025, 06:31
PiRK updated the diff for D18582: kernel: Move non-kernel db cache size constants.

rebase

Sep 10 2025, 06:31
PiRK accepted D18589: [Cashtab] If user selects a non-active wallet in webapp select prompt, activate that wallet.
Sep 10 2025, 06:30
PiRK accepted D18588: [Cashtab] Show an extension-advertising toast to users on chrome/brave desktop who do not have the extension installed.
Sep 10 2025, 06:22
PiRK updated the diff for D18581: kernel: Move kernel-specific cache size options to kernel.

use init-capture (see https://burnicki.pl/en/2021/04/19/capture-structured-bindings.html)

Sep 10 2025, 06:16

Sep 9 2025

PiRK closed D18577: validation: drop maximum -dbcache.
Sep 9 2025, 15:28
PiRK closed D18576: qt: add missing tooltips to options menu settings.
Sep 9 2025, 15:28
PiRK committed rABC63811758c046: qt: add missing tooltips to options menu settings (authored by Jarol Rodriguez <jarolrod@tutanota.com>).
qt: add missing tooltips to options menu settings
Sep 9 2025, 15:28
PiRK committed rABCd0871d7268ae: validation: drop maximum -dbcache (authored by Sjors Provoost <sjors@sprovoost.nl>).
validation: drop maximum -dbcache
Sep 9 2025, 15:28
PiRK closed D18575: validation: don't clear cache on periodic flush.
Sep 9 2025, 15:28
PiRK committed rABC02e5b148b44f: validation: don't clear cache on periodic flush (authored by Andrew Toth <andrewstoth@gmail.com>).
validation: don't clear cache on periodic flush
Sep 9 2025, 15:28
PiRK planned changes to D18584: init: Use size_t consistently for cache sizes.
Sep 9 2025, 14:22
PiRK planned changes to D18583: kernel: Move default cache constants to caches.
Sep 9 2025, 14:21
PiRK planned changes to D18582: kernel: Move non-kernel db cache size constants.

needs rebase after D18581 is fixed

Sep 9 2025, 14:21
PiRK planned changes to D18581: kernel: Move kernel-specific cache size options to kernel.

looks like this includes c++20 code

Sep 9 2025, 14:21
PiRK requested review of D18584: init: Use size_t consistently for cache sizes.
Sep 9 2025, 13:58
PiRK requested review of D18583: kernel: Move default cache constants to caches.
Sep 9 2025, 13:57
PiRK requested review of D18582: kernel: Move non-kernel db cache size constants.
Sep 9 2025, 13:56