Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Sep 10 2018

qshuai requested review of D1447: fix confusing parameter information.
Sep 10 2018, 12:19

Aug 9 2018

qshuai added a comment to D1447: fix confusing parameter information.

This pr needs more discussion?

Aug 9 2018, 16:44

Jun 29 2018

qshuai updated the test plan for D1447: fix confusing parameter information.
Jun 29 2018, 01:59

Jun 22 2018

qshuai updated the summary of D1447: fix confusing parameter information.
Jun 22 2018, 14:09
qshuai updated the test plan for D1447: fix confusing parameter information.
Jun 22 2018, 14:00

May 25 2018

qshuai added a comment to D1447: fix confusing parameter information.
In D1447#29304, @deadalnix wrote:

Please explain what was confusing in the existing example.
Also please fill out a test plan that someone can follow.

May 25 2018, 03:18
Herald added a reviewer for D1453: fix confusing parameter information: Restricted Project.
May 25 2018, 02:30

May 24 2018

Herald added a reviewer for D1447: fix confusing parameter information: Restricted Project.
May 24 2018, 10:15
qshuai abandoned D1305: Calculated nBits by UpdateTime() will be replaced by following code.
May 24 2018, 09:19

Apr 25 2018

qshuai updated subscribers of D1305: Calculated nBits by UpdateTime() will be replaced by following code.

@deadalnix @jasonb The following picture shows UpdateTime() function calling.

WX20180425-114504.png (315×470 px, 21 KB)
I think my diff do not break testnet. As to testnet, if CreateNewBlock() function not be called, the block's nBits item will not be updated, and it's nBits item using the previous pblocktemplate's. I mean the pblocktemplate's nBits item should not be updated until receiving a new block from network.
The following code is the condition of calling CreateNewBlock() function :

Apr 25 2018, 03:59

Apr 24 2018

qshuai added a comment to D1305: Calculated nBits by UpdateTime() will be replaced by following code.

There are two reasons to remove the code(as you see):
The calculated nBits will be replaced by the following GetNextWorkRequired(.) function. So calculating difficulty(nBits) in UpdateTime() function is meaningless. The main chain does not matter. But testnet will exec twice.
UpdateTime() function should remain single role for updating timestamp item of block.

Apr 24 2018, 07:48
Herald added a reviewer for D1305: Calculated nBits by UpdateTime() will be replaced by following code: Restricted Project.
Apr 24 2018, 07:44