Page MenuHomePhabricator

alitayin (alitayin)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 30 2022, 13:06 (170 w, 5 d)

Recent Activity

Tue, May 6

alitayin closed D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.
Tue, May 6, 02:08
alitayin committed rABC973fbe8030ca: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization (authored by alitayin).
[Cashtab] Set ConnectionStrategy.ClosestFirst for initialization
Tue, May 6, 02:08

Mon, May 5

alitayin requested review of D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.

I tried shortening the timeout to 500ms and performed some tests. I found that the selection strategy doesn't slow down the user's startup experience; instead, it might make it faster. The user's actual complete loading occurs when the "loading" state disappears, which is loadCashtabState in useWallet.ts. Through adding a timer for simple testing, taking my Hong Kong IP as an example, useWallet.ts:969 shows Cashtab startup duration: 2583ms. This is the time actually perceived by users. However, when using the "selection strategy" and changing the timeout from 1000ms to 500ms, the test result is 620ms for Cashtab startup duration. Therefore, finding a faster node within 500ms and establishing a connection is often faster than choosing a default one. Furthermore, this 500ms could potentially be adjusted to 400ms or 300ms, meaning "if we can't find a faster node within 300-400ms, it doesn't matter anymore." WebSocket connection establishment speed is 2-3 times that of ping, and it's easy to prove through testing that lower WebSocket latency means lower query latency.

Mon, May 5, 04:37

Sun, May 4

alitayin added a comment to D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.

My view is that this approach is worthwhile.

Sun, May 4, 02:16

Fri, May 2

alitayin added inline comments to D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.
Fri, May 2, 00:28

Thu, May 1

teamcity awarded D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization a Haypence token.
Thu, May 1, 20:08
alitayin requested review of D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.
Thu, May 1, 20:02

Mon, Apr 28

alitayin closed D17974: [chronik-client] Fix WebSocket retry loop issues during disconnection.
Mon, Apr 28, 14:00
alitayin committed rABCca9b14c07a55: [chronik-client] Fix WebSocket retry loop issues during disconnection (authored by alitayin).
[chronik-client] Fix WebSocket retry loop issues during disconnection
Mon, Apr 28, 14:00
alitayin updated the diff for D17974: [chronik-client] Fix WebSocket retry loop issues during disconnection.

rebuild again :-) please

Mon, Apr 28, 10:06
alitayin updated the diff for D17974: [chronik-client] Fix WebSocket retry loop issues during disconnection.

Add test for manual close

Mon, Apr 28, 09:46
alitayin added a comment to D18001: [cashtab] Mobile style fixes.

@bot preview-cashtab

Mon, Apr 28, 06:43

Sat, Apr 26

alitayin updated the diff for D17974: [chronik-client] Fix WebSocket retry loop issues during disconnection.

Add README.md and npm version patch

Sat, Apr 26, 18:35
alitayin updated the summary of D17974: [chronik-client] Fix WebSocket retry loop issues during disconnection.
Sat, Apr 26, 18:24
alitayin updated the diff for D17974: [chronik-client] Fix WebSocket retry loop issues during disconnection.

Removed the previous delay handling. Only ensure in this diff that faulty nodes can be switched correctly.

Sat, Apr 26, 18:17

Thu, Apr 24

alitayin added a comment to D17974: [chronik-client] Fix WebSocket retry loop issues during disconnection.

Based on offline discussions,
Joey's view is correct. "A node that can establish a WebSocket connection (_websocketUrlConnects) but immediately throws onerror or onclose after connection" was inferred from a March failure,

Thu, Apr 24, 17:37
alitayin updated the summary of D17974: [chronik-client] Fix WebSocket retry loop issues during disconnection.
Thu, Apr 24, 04:50
alitayin requested review of D17974: [chronik-client] Fix WebSocket retry loop issues during disconnection.

“A node that can establish a WebSocket connection (_websocketUrlConnects) but immediately throws onerror or onclose after connecting,” is not an accurate description; it’s more of an extreme example.

Thu, Apr 24, 04:46

Wed, Apr 23

alitayin added inline comments to D17974: [chronik-client] Fix WebSocket retry loop issues during disconnection.
Wed, Apr 23, 09:58
alitayin added inline comments to D17974: [chronik-client] Fix WebSocket retry loop issues during disconnection.
Wed, Apr 23, 09:50
alitayin updated the summary of D17974: [chronik-client] Fix WebSocket retry loop issues during disconnection.
Wed, Apr 23, 07:40
alitayin updated the test plan for D17974: [chronik-client] Fix WebSocket retry loop issues during disconnection.
Wed, Apr 23, 06:58
alitayin requested review of D17974: [chronik-client] Fix WebSocket retry loop issues during disconnection.
Wed, Apr 23, 06:44

Tue, Apr 22

alitayin closed D17949: [chronik-client] Add handling for WebSocket closure .
Tue, Apr 22, 20:26
alitayin committed rABCd27e5156c299: [chronik-client] Add handling for WebSocket closure (authored by alitayin).
[chronik-client] Add handling for WebSocket closure
Tue, Apr 22, 20:26
alitayin added a comment to D17949: [chronik-client] Add handling for WebSocket closure .

This diff will only address the issue of _websocketUrlConnects not closing the WebSocket under timeout conditions.

Tue, Apr 22, 20:15
alitayin updated the summary of D17949: [chronik-client] Add handling for WebSocket closure .
Tue, Apr 22, 20:13

Fri, Apr 18

alitayin added inline comments to D17949: [chronik-client] Add handling for WebSocket closure .
Fri, Apr 18, 17:27
alitayin retitled D17949: [chronik-client] Add handling for WebSocket closure from [chronik-client] Add handling for WebSocket closure and add delay for reconnection to [chronik-client] Add handling for WebSocket closure .
Fri, Apr 18, 17:12
alitayin updated the summary of D17949: [chronik-client] Add handling for WebSocket closure .
Fri, Apr 18, 17:12
alitayin updated the diff for D17949: [chronik-client] Add handling for WebSocket closure .

keep the first modification to close WS

Fri, Apr 18, 17:10
alitayin requested review of D17949: [chronik-client] Add handling for WebSocket closure .
Fri, Apr 18, 03:27

Thu, Apr 17

alitayin closed D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Thu, Apr 17, 23:33
alitayin committed rABC0eaa9c9c1589: [chronik-client] Added a mechanism for automatically selecting the fastest… (authored by alitayin).
[chronik-client] Added a mechanism for automatically selecting the fastest…
Thu, Apr 17, 23:33
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

Extra comments and trailing whitespace removed

Thu, Apr 17, 15:15
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

update README.md

Thu, Apr 17, 11:57
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

update README.md and npm version minor

Thu, Apr 17, 02:36

Wed, Apr 16

alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

Better test url orders

Wed, Apr 16, 13:44
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

Some minor adjustments regarding the above.

Wed, Apr 16, 12:41
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

add package-json

Wed, Apr 16, 10:02
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

rebase and add test

Wed, Apr 16, 09:53

Tue, Apr 15

alitayin updated the summary of D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Tue, Apr 15, 18:19
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

add test, in the test, i don't mock measureWebsocketLatency, but instead use asynchronous actual testing to
keep it simple.

Tue, Apr 15, 18:09
alitayin added inline comments to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Tue, Apr 15, 14:45
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

Keep using Infinity, adjust the output to display in ms

Tue, Apr 15, 14:44
alitayin added inline comments to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Tue, Apr 15, 14:27
alitayin added inline comments to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Tue, Apr 15, 14:20
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

Directly return -1 in measureWebsocketLatency for timeout cases

Tue, Apr 15, 13:36
alitayin added inline comments to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Tue, Apr 15, 13:22
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

Based on what was mentioned earlier, I first moved appendWsUrls out of the class in D17935 and reused it here.
Additionally, I removed the concurrent and batch settings, and optimized and streamlined the Sort function (the
original sort function considered multiple rounds of testing, making the code more complicated)

Tue, Apr 15, 13:20
alitayin closed D17935: [chronik-client] Move appendWsUrls out of the class as a public function.
Tue, Apr 15, 10:35
alitayin committed rABCcfd0d9a04c28: [chronik-client] Move appendWsUrls out of the class as a public function (authored by alitayin).
[chronik-client] Move appendWsUrls out of the class as a public function
Tue, Apr 15, 10:35
alitayin requested review of D17935: [chronik-client] Move appendWsUrls out of the class as a public function.
Tue, Apr 15, 10:08
alitayin updated the summary of D17935: [chronik-client] Move appendWsUrls out of the class as a public function.
Tue, Apr 15, 10:08
alitayin retitled D17935: [chronik-client] Move appendWsUrls out of the class as a public function from [chronik.e.cash] Move appendWsUrls out of the class as a public function to [chronik-client] Move appendWsUrls out of the class as a public function.
Tue, Apr 15, 09:22
alitayin requested review of D17935: [chronik-client] Move appendWsUrls out of the class as a public function.
Tue, Apr 15, 09:07

Sat, Apr 12

alitayin added inline comments to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Sat, Apr 12, 09:45

Thu, Apr 10

alitayin added a comment to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

// Using the static method with strategy
const chronik = await ChronikClient.useStrategy(

ConnectionStrategy.ClosestFirst, 
urls,
maxConcurrentTests // optional parameter, default is 20

);

Thu, Apr 10, 23:34
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

Node selection is implemented using static methods in chronikclient while maintaining consistency with existing methods. Removed the original npm list
test. Moved measureWebsocketLatency and sortNodesByLatency to chronikclient.ts

Thu, Apr 10, 23:28

Apr 10 2025

alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

After this modification, it no longer dynamically selects the best node. Instead, it rearranges the
node order only once during initialization. Removed the URL string and kept only the array to maintain consistency with chronikclient.
And use as-order as default

Apr 10 2025, 10:01
alitayin updated the diff for D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

After this modification, it no longer dynamically selects the best node. Instead, it rearranges the node order only once during
initialization. Removed the URL string and kept only the array to maintain consistency with chronikclient.

Apr 10 2025, 09:10

Apr 9 2025

alitayin requested review of D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Apr 9 2025, 08:25
alitayin added a comment to D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..

I have tested the modified chronik-client locally and it switches smoothly. Perhaps I could deploy it on an actual test domain for public testing?

Apr 9 2025, 08:24

Apr 8 2025

alitayin requested review of D17913: [chronik-client] Added a mechanism for automatically selecting the fastest responding node, supporting two strategies: AsOrdered and ClosestFirst..
Apr 8 2025, 19:32

Apr 6 2025

alitayin closed D17903: [Cashtab] Add 2 chronik nodes.
Apr 6 2025, 05:50
alitayin committed rABC9827da089165: [Cashtab] Add 2 chronik nodes (authored by alitayin).
[Cashtab] Add 2 chronik nodes
Apr 6 2025, 05:50

Apr 5 2025

alitayin requested review of D17903: [Cashtab] Add 2 chronik nodes.
Apr 5 2025, 20:35

Apr 3 2025

alitayin closed D17884: [chronik.e.cash] enable trailing slashes for consistent URL structure.
Apr 3 2025, 07:38
alitayin committed rABC431239ff5459: [chronik.e.cash] enable trailing slashes for consistent URL structure (authored by alitayin).
[chronik.e.cash] enable trailing slashes for consistent URL structure
Apr 3 2025, 07:38
alitayin requested review of D17884: [chronik.e.cash] enable trailing slashes for consistent URL structure.
Apr 3 2025, 06:49

Apr 2 2025

alitayin closed D17815: [Cashtab] Introduce CSS variables to make styling easier.
Apr 2 2025, 18:23
alitayin committed rABCbc594abfd601: [Cashtab] Introduce CSS variables to make styling easier (authored by alitayin).
[Cashtab] Introduce CSS variables to make styling easier
Apr 2 2025, 18:23
alitayin updated the diff for D17815: [Cashtab] Introduce CSS variables to make styling easier.

--update D17815

Apr 2 2025, 18:22

Mar 28 2025

alitayin requested review of D17815: [Cashtab] Introduce CSS variables to make styling easier.
Mar 28 2025, 06:24
alitayin added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
Mar 28 2025, 02:01

Mar 21 2025

alitayin added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
Mar 21 2025, 15:16
alitayin added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
Mar 21 2025, 06:19
alitayin added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
Mar 21 2025, 05:38

Mar 20 2025

alitayin updated the diff for D17815: [Cashtab] Introduce CSS variables to make styling easier.

Switch to my branch and commit again.

Mar 20 2025, 01:34

Mar 19 2025

alitayin updated the diff for D17815: [Cashtab] Introduce CSS variables to make styling easier.

Completed the above modifications

Mar 19 2025, 17:25
alitayin abandoned D17828: [Cashtab] Introduce CSS variables to make styling easier.
Mar 19 2025, 17:22
alitayin requested review of D17828: [Cashtab] Introduce CSS variables to make styling easier.
Mar 19 2025, 16:58
alitayin added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
Mar 19 2025, 04:45
alitayin added a comment to D17815: [Cashtab] Introduce CSS variables to make styling easier.

would be a good change and help to get some of the css more standardized in Cashtab

Mar 19 2025, 03:02
alitayin added a comment to D17815: [Cashtab] Introduce CSS variables to make styling easier.
Mar 19 2025, 02:51
alitayin added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
Mar 19 2025, 02:44

Mar 18 2025

alitayin updated the diff for D17815: [Cashtab] Introduce CSS variables to make styling easier.

[Cashtab] Introduce CSS variables to make styling easier

Mar 18 2025, 15:16
alitayin requested review of D17815: [Cashtab] Introduce CSS variables to make styling easier.
Mar 18 2025, 15:00

Mar 16 2025

alitayin closed D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.
Mar 16 2025, 23:09
alitayin committed rABC767f0d39a1db: [Cashtab] Add click-outside-area closing effect for NavWrapper using event… (authored by alitayin).
[Cashtab] Add click-outside-area closing effect for NavWrapper using event…
Mar 16 2025, 23:09

Mar 11 2025

alitayin updated the diff for D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

An attempt to resolve a missing base commit

Mar 11 2025, 15:01

Mar 10 2025

alitayin updated the diff for D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

[Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling

Mar 10 2025, 03:54
alitayin updated the diff for D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

lint

Mar 10 2025, 03:47
alitayin updated the diff for D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

remove stopPropagation

Mar 10 2025, 03:43
alitayin updated the diff for D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Updating D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling

Mar 10 2025, 02:53

Mar 6 2025

alitayin updated the diff for D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Squashed commits as requested and removed unnecessary useEffec

Mar 6 2025, 09:20
alitayin added a comment to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Implemented a click-outside closing mechanism for the settings window

where is this implemented? I'm not seeing event bubbling above, only the removal of the redundant useEffect.

Mar 6 2025, 08:49
alitayin retitled D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling from Add click-outside-area closing effect for NavWrapper using event bubbling to [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.
Mar 6 2025, 08:40
alitayin updated the diff for D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Remove useEffect

Mar 6 2025, 05:27
alitayin requested review of D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.
Mar 6 2025, 05:21