Page MenuHomePhabricator
People fpelliccioni

fpelliccioni (Fernando Pelliccioni)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2017, 18:09 (393 w, 5 d)

Recent Activity
View All

Apr 7 2020

fpelliccioni committed rSTAGINGbd6d5140b5c1: Make last disconnected block BLOCK_FAILED_VALID, even when aborted (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make last disconnected block BLOCK_FAILED_VALID, even when aborted
Apr 7 2020, 22:37
fpelliccioni committed rSTAGINGe7fc0238127a: Optimization: don't add txn back to mempool after 10 invalidates (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Optimization: don't add txn back to mempool after 10 invalidates
Apr 7 2020, 22:28
fpelliccioni committed rSTAGINGa9734a4e30ae: Prevent callback overruns in InvalidateBlock and RewindBlockIndex (authored by fpelliccioni).
Prevent callback overruns in InvalidateBlock and RewindBlockIndex
Apr 7 2020, 22:27
fpelliccioni committed rSTAGINGbaef60890b54: Call FinalizeBlockAndInvalidate without cs_main held (authored by fpelliccioni).
Call FinalizeBlockAndInvalidate without cs_main held
Apr 7 2020, 22:27
fpelliccioni committed rSTAGING3fb45c049a4c: Release cs_main during InvalidateBlock iterations (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Release cs_main during InvalidateBlock iterations
Apr 7 2020, 22:26
fpelliccioni committed rSTAGING9096e76f01e5: Call InvalidateBlock without cs_main held (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Call InvalidateBlock without cs_main held
Apr 7 2020, 22:26
fpelliccioni committed rSTAGING7504e09fda75: Call RewindBlockIndex without cs_main held (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
Call RewindBlockIndex without cs_main held
Apr 7 2020, 22:26
fpelliccioni committed rSTAGING197e349654be: We assume uint8_t is an alias of unsigned char. (authored by fpelliccioni).
We assume uint8_t is an alias of unsigned char.
Apr 7 2020, 22:07
fpelliccioni committed rSTAGING6dbaecb2d494: Fixes AES benchmarks (authored by fpelliccioni).
Fixes AES benchmarks
Apr 7 2020, 22:06
fpelliccioni committed rSTAGING4b92e0e79051: Abstract EraseBlockData out of RewindBlockIndex (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Abstract EraseBlockData out of RewindBlockIndex
Apr 7 2020, 22:03
fpelliccioni committed rSTAGINGba82bd9f9256: refactor: Add and use HaveTxsDownloaded() where appropriate (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Add and use HaveTxsDownloaded() where appropriate
Apr 7 2020, 21:58
fpelliccioni committed rSTAGINGf316cd272e95: rpc: Expose g_is_mempool_loaded via getmempoolinfo (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Expose g_is_mempool_loaded via getmempoolinfo
Apr 7 2020, 21:31
fpelliccioni committed rSTAGINGe12d2c2449ee: bench: Benchmark MempoolToJSON (authored by MarcoFalke <falke.marco@gmail.com>).
bench: Benchmark MempoolToJSON
Apr 7 2020, 21:30
fpelliccioni committed rSTAGINGa76b928ad0d6: mempool: remove unused magic number from consistency check (authored by Gregory Sanders <gsanders87@gmail.com>).
mempool: remove unused magic number from consistency check
Apr 7 2020, 21:28
fpelliccioni committed rSTAGINGd2a40c0a60e2: [mempool] Mark mempool import fails that were found in mempool as 'already… (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[mempool] Mark mempool import fails that were found in mempool as 'already…
Apr 7 2020, 21:27

Jan 24 2020

fpelliccioni abandoned D5043: refactor: rename chainActive.
Jan 24 2020, 13:07

Jan 23 2020

fpelliccioni updated the summary of D5056: refactoring: introduce unused ChainActive().
Jan 23 2020, 18:40
fpelliccioni created D5056: refactoring: introduce unused ChainActive().
Jan 23 2020, 18:38
fpelliccioni requested review of D5055: rename: CChainState.chainActive -> m_chain.
Jan 23 2020, 18:22
fpelliccioni updated the summary of D5055: rename: CChainState.chainActive -> m_chain.
Jan 23 2020, 18:21
fpelliccioni updated the summary of D5055: rename: CChainState.chainActive -> m_chain.
Jan 23 2020, 18:21
fpelliccioni updated the summary of D5055: rename: CChainState.chainActive -> m_chain.
Jan 23 2020, 18:19
fpelliccioni retitled D5055: rename: CChainState.chainActive -> m_chain from refactor: rename chainActive to rename: CChainState.chainActive -> m_chain.
Jan 23 2020, 18:17
fpelliccioni planned changes to D5055: rename: CChainState.chainActive -> m_chain.
Jan 23 2020, 18:17
fpelliccioni created D5055: rename: CChainState.chainActive -> m_chain.
Jan 23 2020, 18:16
fpelliccioni planned changes to D5043: refactor: rename chainActive.
Jan 23 2020, 17:52

Jan 22 2020

fpelliccioni updated the diff for D5043: refactor: rename chainActive.

squashed commits

Jan 22 2020, 18:49
fpelliccioni planned changes to D5043: refactor: rename chainActive.
Jan 22 2020, 18:46
fpelliccioni updated the summary of D5043: refactor: rename chainActive.
Jan 22 2020, 18:43
fpelliccioni updated the test plan for D5043: refactor: rename chainActive.
Jan 22 2020, 18:42
fpelliccioni created D5043: refactor: rename chainActive.
Jan 22 2020, 18:42
fpelliccioni accepted D5041: Fix parent<->child mixup in UnwindBlock.
Jan 22 2020, 15:39

Jan 21 2020

fpelliccioni committed rABCbd6d5140b5c1: Make last disconnected block BLOCK_FAILED_VALID, even when aborted (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make last disconnected block BLOCK_FAILED_VALID, even when aborted
Jan 21 2020, 21:45
fpelliccioni closed D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Jan 21 2020, 21:45

Jan 20 2020

fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

fixes code comments

Jan 20 2020, 17:39
fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

reverted code

Jan 20 2020, 17:29
fpelliccioni planned changes to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Jan 20 2020, 17:27
fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

remove reverted code

Jan 20 2020, 17:26
fpelliccioni abandoned D4945: Revert D4942 locking 'time'.

The final revert is done in D4946

Jan 20 2020, 17:20
fpelliccioni planned changes to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Jan 20 2020, 15:34
fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

rebase from master

Jan 20 2020, 15:31

Jan 16 2020

fpelliccioni retitled D4950: Fully revert D4803 due to TSAN test failures from Partially revert D4803 due to TSAN test failures to Fully revert D4803 due to TSAN test failures.
Jan 16 2020, 01:05
fpelliccioni updated the diff for D4950: Fully revert D4803 due to TSAN test failures.

full revert

Jan 16 2020, 01:04

Jan 15 2020

fpelliccioni updated the test plan for D4950: Fully revert D4803 due to TSAN test failures.
Jan 15 2020, 19:14
fpelliccioni added a reverting change for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex: D4950: Fully revert D4803 due to TSAN test failures.
Jan 15 2020, 19:13
fpelliccioni created D4950: Fully revert D4803 due to TSAN test failures.
Jan 15 2020, 19:13
fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

fixes

Jan 15 2020, 18:04
fpelliccioni committed rABCe7fc0238127a: Optimization: don't add txn back to mempool after 10 invalidates (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Optimization: don't add txn back to mempool after 10 invalidates
Jan 15 2020, 17:37
fpelliccioni closed D4804: Optimization: don't add txn back to mempool after 10 invalidates.
Jan 15 2020, 17:37
fpelliccioni updated the diff for D4804: Optimization: don't add txn back to mempool after 10 invalidates.

rebase from master

Jan 15 2020, 17:10
fpelliccioni committed rABCa9734a4e30ae: Prevent callback overruns in InvalidateBlock and RewindBlockIndex (authored by fpelliccioni).
Prevent callback overruns in InvalidateBlock and RewindBlockIndex
Jan 15 2020, 17:08
fpelliccioni closed D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Jan 15 2020, 17:07
fpelliccioni updated the summary of D4945: Revert D4942 locking 'time'.
Jan 15 2020, 12:53
fpelliccioni updated the diff for D4945: Revert D4942 locking 'time'.

lapsus

Jan 15 2020, 12:52
fpelliccioni planned changes to D4945: Revert D4942 locking 'time'.
Jan 15 2020, 12:52
fpelliccioni updated the summary of D4945: Revert D4942 locking 'time'.
Jan 15 2020, 12:51
fpelliccioni created D4945: Revert D4942 locking 'time'.
Jan 15 2020, 12:50

Jan 14 2020

fpelliccioni updated the summary of D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Jan 14 2020, 21:27
fpelliccioni updated the diff for D4804: Optimization: don't add txn back to mempool after 10 invalidates.

rebased

Jan 14 2020, 21:26
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

rebase from master

Jan 14 2020, 21:23
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

rebase from master

Jan 14 2020, 21:21
fpelliccioni committed rABCbaef60890b54: Call FinalizeBlockAndInvalidate without cs_main held (authored by fpelliccioni).
Call FinalizeBlockAndInvalidate without cs_main held
Jan 14 2020, 21:13
fpelliccioni closed D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Jan 14 2020, 21:13
fpelliccioni updated the diff for D4942: Call FinalizeBlockAndInvalidate without cs_main held.

linting

Jan 14 2020, 20:03
fpelliccioni updated the diff for D4942: Call FinalizeBlockAndInvalidate without cs_main held.

lock frame reduced

Jan 14 2020, 20:02
fpelliccioni added inline comments to D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Jan 14 2020, 19:49
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

rebased

Jan 14 2020, 17:22
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

add whitespace

Jan 14 2020, 17:19
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

revert not related with PR code

Jan 14 2020, 17:17
fpelliccioni updated the summary of D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Jan 14 2020, 17:12
fpelliccioni planned changes to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Jan 14 2020, 16:11
fpelliccioni added a reviewer for D4942: Call FinalizeBlockAndInvalidate without cs_main held: markblundeberg.
Jan 14 2020, 16:10
fpelliccioni updated the diff for D4942: Call FinalizeBlockAndInvalidate without cs_main held.

rebased from master

Jan 14 2020, 16:09
fpelliccioni committed rABC3fb45c049a4c: Release cs_main during InvalidateBlock iterations (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Release cs_main during InvalidateBlock iterations
Jan 14 2020, 16:05
fpelliccioni closed D4802: Release cs_main during InvalidateBlock iterations.
Jan 14 2020, 16:05
fpelliccioni updated the diff for D4802: Release cs_main during InvalidateBlock iterations.

rebased from master

Jan 14 2020, 15:56
fpelliccioni planned changes to D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Jan 14 2020, 15:53
fpelliccioni created D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Jan 14 2020, 15:52
fpelliccioni committed rABC9096e76f01e5: Call InvalidateBlock without cs_main held (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Call InvalidateBlock without cs_main held
Jan 14 2020, 15:28
fpelliccioni closed D4758: Call InvalidateBlock without cs_main held.
Jan 14 2020, 15:28
fpelliccioni updated the diff for D4758: Call InvalidateBlock without cs_main held.

rebase from master

Jan 14 2020, 15:20
fpelliccioni committed rABC7504e09fda75: Call RewindBlockIndex without cs_main held (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
Call RewindBlockIndex without cs_main held
Jan 14 2020, 15:19
fpelliccioni closed D4757: Call RewindBlockIndex without cs_main held.
Jan 14 2020, 15:19
fpelliccioni updated the diff for D4757: Call RewindBlockIndex without cs_main held.

rebase from master

Jan 14 2020, 15:12

Jan 13 2020

fpelliccioni updated the diff for D4804: Optimization: don't add txn back to mempool after 10 invalidates.

braces

Jan 13 2020, 18:16
fpelliccioni requested review of D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Jan 13 2020, 18:15
fpelliccioni added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
In D4803#118361, @deadalnix wrote:

This clearly includes a lot of code that isn't in the original PR. Where does the clocking mechanism changes come from?

Jan 13 2020, 18:13
fpelliccioni retitled D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted from Granular invalidateblock and RewindBlockIndex to Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Jan 13 2020, 18:04
fpelliccioni planned changes to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Jan 13 2020, 18:02
fpelliccioni created D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Jan 13 2020, 18:01

Jan 10 2020

fpelliccioni updated the test plan for D4804: Optimization: don't add txn back to mempool after 10 invalidates.
Jan 10 2020, 18:59
fpelliccioni updated the diff for D4804: Optimization: don't add txn back to mempool after 10 invalidates.

rebase

Jan 10 2020, 18:57
fpelliccioni updated the test plan for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Jan 10 2020, 18:35
fpelliccioni added inline comments to D4758: Call InvalidateBlock without cs_main held.
Jan 10 2020, 18:34
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

Call FinalizeBlockAndInvalidate without cs_main held

Jan 10 2020, 18:32
fpelliccioni updated the test plan for D4802: Release cs_main during InvalidateBlock iterations.
Jan 10 2020, 13:47

Jan 8 2020

fpelliccioni updated the diff for D4802: Release cs_main during InvalidateBlock iterations.

Remove code that removes from setBlockIndexCandidates as FindMostWorkChain() is in charge of it.

Jan 8 2020, 18:46

Jan 7 2020

fpelliccioni added inline comments to D4802: Release cs_main during InvalidateBlock iterations.
Jan 7 2020, 16:01
fpelliccioni updated the diff for D4802: Release cs_main during InvalidateBlock iterations.

fixes suggested

Jan 7 2020, 15:32

Jan 3 2020

fpelliccioni updated the diff for D4802: Release cs_main during InvalidateBlock iterations.

fixes tests

Jan 3 2020, 16:21