Page MenuHomePhabricator
Feed Advanced Search

Thu, Dec 12

fpelliccioni updated the diff for D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex.

remove code section

Thu, Dec 12, 18:12
fpelliccioni committed rABC4b92e0e79051: Abstract EraseBlockData out of RewindBlockIndex (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Abstract EraseBlockData out of RewindBlockIndex
Thu, Dec 12, 17:57
fpelliccioni closed D4653: Abstract EraseBlockData out of RewindBlockIndex.
Thu, Dec 12, 17:57
fpelliccioni updated the diff for D4653: Abstract EraseBlockData out of RewindBlockIndex.

moved comment

Thu, Dec 12, 17:55

Wed, Dec 11

fpelliccioni added inline comments to D4683: Merge the disconnection and erasing loops in RewindBlockIndex.
Wed, Dec 11, 13:05

Tue, Dec 10

fpelliccioni retitled D4684: Release cs_main during RewindBlockIndex operation from Granular invalidateblock and RewindBlockIndex to Release cs_main during RewindBlockIndex operation.
Tue, Dec 10, 18:12
fpelliccioni created D4684: Release cs_main during RewindBlockIndex operation.
Tue, Dec 10, 18:10
fpelliccioni updated the summary of D4683: Merge the disconnection and erasing loops in RewindBlockIndex.
Tue, Dec 10, 15:11
fpelliccioni retitled D4683: Merge the disconnection and erasing loops in RewindBlockIndex from Granular invalidateblock and RewindBlockIndex to Merge the disconnection and erasing loops in RewindBlockIndex.
Tue, Dec 10, 15:10
fpelliccioni created D4683: Merge the disconnection and erasing loops in RewindBlockIndex.
Tue, Dec 10, 15:08

Mon, Dec 9

fpelliccioni updated the summary of D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex.
Mon, Dec 9, 17:26
fpelliccioni retitled D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex from Granular invalidateblock and RewindBlockIndex to Move erasure of non-active blocks to a separate loop in RewindBlockIndex.
Mon, Dec 9, 17:25
fpelliccioni created D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex.
Mon, Dec 9, 17:23
fpelliccioni retitled D4653: Abstract EraseBlockData out of RewindBlockIndex from Granular invalidateblock and RewindBlockIndex (Partial) to Abstract EraseBlockData out of RewindBlockIndex.
Mon, Dec 9, 15:59
fpelliccioni updated the diff for D4653: Abstract EraseBlockData out of RewindBlockIndex.

Solved Bitcoin-QT test

Mon, Dec 9, 15:25
fpelliccioni retitled D4653: Abstract EraseBlockData out of RewindBlockIndex from Granular invalidateblock and RewindBlockIndex to Granular invalidateblock and RewindBlockIndex (Partial).
Mon, Dec 9, 14:39
fpelliccioni abandoned D4550: crypto: Remove unused AES-128 code.
Mon, Dec 9, 14:23

Thu, Dec 5

fpelliccioni added a comment to D4550: crypto: Remove unused AES-128 code.

I think we may want to keep this around for QUIC.

Thu, Dec 5, 19:31
fpelliccioni requested review of D4653: Abstract EraseBlockData out of RewindBlockIndex.
Thu, Dec 5, 19:30
fpelliccioni updated the summary of D4653: Abstract EraseBlockData out of RewindBlockIndex.
Thu, Dec 5, 19:29
fpelliccioni updated the summary of D4653: Abstract EraseBlockData out of RewindBlockIndex.
Thu, Dec 5, 19:27
fpelliccioni planned changes to D4653: Abstract EraseBlockData out of RewindBlockIndex.

Need to adjust Summary

Thu, Dec 5, 19:20
fpelliccioni created D4653: Abstract EraseBlockData out of RewindBlockIndex.
Thu, Dec 5, 19:19

Mon, Dec 2

fpelliccioni committed rABCba82bd9f9256: refactor: Add and use HaveTxsDownloaded() where appropriate (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Add and use HaveTxsDownloaded() where appropriate
Mon, Dec 2, 18:03
fpelliccioni closed D4552: refactor: Add and use HaveTxsDownloaded() where appropriate.
Mon, Dec 2, 18:03
fpelliccioni updated the diff for D4552: refactor: Add and use HaveTxsDownloaded() where appropriate.

rebase from master

Mon, Dec 2, 17:19

Tue, Nov 26

fpelliccioni requested review of D4550: crypto: Remove unused AES-128 code.
Tue, Nov 26, 19:57
fpelliccioni updated the test plan for D4550: crypto: Remove unused AES-128 code.
Tue, Nov 26, 19:57
fpelliccioni planned changes to D4550: crypto: Remove unused AES-128 code.

I have to update the test plan.

Tue, Nov 26, 19:16
fpelliccioni updated the test plan for D4552: refactor: Add and use HaveTxsDownloaded() where appropriate.
Tue, Nov 26, 19:14
fpelliccioni created D4552: refactor: Add and use HaveTxsDownloaded() where appropriate.
Tue, Nov 26, 19:14
fpelliccioni updated the test plan for D4550: crypto: Remove unused AES-128 code.
Tue, Nov 26, 13:49
fpelliccioni created D4550: crypto: Remove unused AES-128 code.
Tue, Nov 26, 13:48

Tue, Nov 19

fpelliccioni abandoned D4280: Minor cleanups for AcceptToMemoryPool.
Tue, Nov 19, 17:06
fpelliccioni abandoned D4075: Integration of property based testing into Bitcoin Core.
Tue, Nov 19, 17:05
fpelliccioni abandoned D4009: zmq: log outbound message high water mark when reusing socket.
Tue, Nov 19, 17:05

Oct 29 2019

fpelliccioni committed rABCf316cd272e95: rpc: Expose g_is_mempool_loaded via getmempoolinfo (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Expose g_is_mempool_loaded via getmempoolinfo
Oct 29 2019, 14:46
fpelliccioni closed D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 29 2019, 14:46
fpelliccioni updated the diff for D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

rebase from master

Oct 29 2019, 14:29

Oct 25 2019

fpelliccioni updated the diff for D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

Applies backport changes.

Oct 25 2019, 14:58
fpelliccioni committed rABCe12d2c2449ee: bench: Benchmark MempoolToJSON (authored by MarcoFalke <falke.marco@gmail.com>).
bench: Benchmark MempoolToJSON
Oct 25 2019, 13:56
fpelliccioni closed D4234: bench: Benchmark MempoolToJSON.
Oct 25 2019, 13:56

Oct 24 2019

fpelliccioni requested review of D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

Please see my previous comment clarifying how I made the rebase.

Oct 24 2019, 19:12
fpelliccioni added a comment to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

Actually do the rebase an the backport, not just run the git rebase command.

Oct 24 2019, 18:39
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

fixes forward declarations order.

Oct 24 2019, 18:21

Oct 23 2019

fpelliccioni updated the diff for D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

rebased

Oct 23 2019, 19:16
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

rebased

Oct 23 2019, 18:33
fpelliccioni updated the test plan for D4234: bench: Benchmark MempoolToJSON.
Oct 23 2019, 18:07
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

fixes wrong rebase

Oct 23 2019, 16:19
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

rebased from master

Oct 23 2019, 15:56
fpelliccioni updated the test plan for D4186: refactor: Avoid locking tx pool cs thrice.
Oct 23 2019, 14:43
fpelliccioni updated the test plan for D4186: refactor: Avoid locking tx pool cs thrice.
Oct 23 2019, 14:43
fpelliccioni updated the test plan for D4186: refactor: Avoid locking tx pool cs thrice.
Oct 23 2019, 14:43

Oct 22 2019

fpelliccioni planned changes to D4280: Minor cleanups for AcceptToMemoryPool.

Have to check what happened with the tests.

Oct 22 2019, 20:03
fpelliccioni updated the test plan for D4280: Minor cleanups for AcceptToMemoryPool.
Oct 22 2019, 19:47
fpelliccioni committed rABCa76b928ad0d6: mempool: remove unused magic number from consistency check (authored by Gregory Sanders <gsanders87@gmail.com>).
mempool: remove unused magic number from consistency check
Oct 22 2019, 19:43
fpelliccioni closed D4278: mempool: remove unused magic number from consistency check.
Oct 22 2019, 19:43
fpelliccioni updated the diff for D4280: Minor cleanups for AcceptToMemoryPool.

removed comment

Oct 22 2019, 19:42
fpelliccioni created D4280: Minor cleanups for AcceptToMemoryPool.
Oct 22 2019, 19:35
fpelliccioni updated the test plan for D4278: mempool: remove unused magic number from consistency check.
Oct 22 2019, 13:39
fpelliccioni created D4278: mempool: remove unused magic number from consistency check.
Oct 22 2019, 13:38

Oct 18 2019

fpelliccioni requested review of D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 18 2019, 14:26
fpelliccioni requested review of D4234: bench: Benchmark MempoolToJSON.
Oct 18 2019, 14:26
fpelliccioni committed rABCd2a40c0a60e2: [mempool] Mark mempool import fails that were found in mempool as 'already… (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[mempool] Mark mempool import fails that were found in mempool as 'already…
Oct 18 2019, 14:24
fpelliccioni closed D4266: [mempool] Mark mempool import fails that were found in mempool as 'already there'.
Oct 18 2019, 14:24

Oct 17 2019

fpelliccioni added a comment to D4234: bench: Benchmark MempoolToJSON.

It's not clear you go the dependency in the right order.in any case, it seems that you have https://github.com/bitcoin/bitcoin/pull/11062 to go through first.

Oct 17 2019, 17:46
fpelliccioni added a comment to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

I think you got the dependency reversed.

Oct 17 2019, 17:46
fpelliccioni updated the summary of D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 17 2019, 17:39
fpelliccioni created D4266: [mempool] Mark mempool import fails that were found in mempool as 'already there'.
Oct 17 2019, 17:39

Oct 16 2019

fpelliccioni added inline comments to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 16 2019, 15:47

Oct 15 2019

fpelliccioni updated the diff for D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

fix the rebase

Oct 15 2019, 14:05
fpelliccioni added a comment to D4234: bench: Benchmark MempoolToJSON.

It looks like you have dependencies to backport first.

Oct 15 2019, 13:58
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

fix rebase error

Oct 15 2019, 13:47
fpelliccioni updated the summary of D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 15 2019, 13:46

Oct 11 2019

fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

fix squashing

Oct 11 2019, 21:14
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

fix squashing.

Oct 11 2019, 21:12
fpelliccioni planned changes to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

I have to fix the squash

Oct 11 2019, 21:10
fpelliccioni updated the test plan for D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 11 2019, 21:09
fpelliccioni created D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 11 2019, 21:08
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

bench code fixed.

Oct 11 2019, 13:09

Oct 10 2019

fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

fix cmake script style.

Oct 10 2019, 17:45
fpelliccioni updated the test plan for D4234: bench: Benchmark MempoolToJSON.
Oct 10 2019, 17:44
fpelliccioni created D4234: bench: Benchmark MempoolToJSON.
Oct 10 2019, 17:43

Oct 9 2019

fpelliccioni committed rSTAGING8408a0cdcf41: mempool, validation: Explain cs_main locking semantics (authored by MarcoFalke <falke.marco@gmail.com>).
mempool, validation: Explain cs_main locking semantics
Oct 9 2019, 20:12
fpelliccioni committed rSTAGING33322f23b3d4: Make objects in range declarations immutable by default. Avoid unnecessary… (authored by practicalswift <practicalswift@users.noreply.github.com>).
Make objects in range declarations immutable by default. Avoid unnecessary…
Oct 9 2019, 20:12
fpelliccioni committed rSTAGING50ae4433e7af: cli: Ignore libevent warnings (authored by Cory Fields <cory-nospam-@coryfields.com>).
cli: Ignore libevent warnings
Oct 9 2019, 20:12
fpelliccioni committed rSTAGINGfb43752bb641: Remove redundant assignments (dead stores) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove redundant assignments (dead stores)
Oct 9 2019, 20:11
fpelliccioni committed rSTAGING5822a6e6efca: refactor: Avoid locking tx pool cs thrice (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Avoid locking tx pool cs thrice
Oct 9 2019, 20:11
fpelliccioni committed rSTAGINGa0dd249c1862: Return void instead of bool for functions that cannot fail (authored by practicalswift <practicalswift@users.noreply.github.com>).
Return void instead of bool for functions that cannot fail
Oct 9 2019, 20:11
fpelliccioni committed rSTAGING6518f3585e5e: validation: Pass tx pool reference into CheckSequenceLocks (authored by MarcoFalke <falke.marco@gmail.com>).
validation: Pass tx pool reference into CheckSequenceLocks
Oct 9 2019, 20:10
fpelliccioni committed rSTAGING44a1e1cd6c81: doxygen: Fix member comments (authored by MarcoFalke <falke.marco@gmail.com>).
doxygen: Fix member comments
Oct 9 2019, 20:10
fpelliccioni committed rABC8408a0cdcf41: mempool, validation: Explain cs_main locking semantics (authored by MarcoFalke <falke.marco@gmail.com>).
mempool, validation: Explain cs_main locking semantics
Oct 9 2019, 17:21
fpelliccioni closed D4227: mempool, validation: Explain cs_main locking semantics.
Oct 9 2019, 17:21
fpelliccioni updated the diff for D4227: mempool, validation: Explain cs_main locking semantics.

fix squashing

Oct 9 2019, 12:37

Oct 8 2019

fpelliccioni planned changes to D4227: mempool, validation: Explain cs_main locking semantics.

I don't know what happened with Squash... I lost some of the changes...

Oct 8 2019, 19:12
fpelliccioni updated the test plan for D4227: mempool, validation: Explain cs_main locking semantics.
Oct 8 2019, 19:10
fpelliccioni created D4227: mempool, validation: Explain cs_main locking semantics.
Oct 8 2019, 19:09
fpelliccioni abandoned D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

Duplicated D4220

Oct 8 2019, 17:47
fpelliccioni added a comment to D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.

Related to Github issue 335:
https://github.com/Bitcoin-ABC/bitcoin-abc/issues/335

Oct 8 2019, 16:44
fpelliccioni added a comment to D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

This is a duplicate of D4220. In addition, it looks like either you either forgot to squash your changes or you are working on a branch with a dependency.

Oct 8 2019, 16:41