HomePhabricator

Fix some compile problems on weird/old compilers.

Description

Fix some compile problems on weird/old compilers.

Summary:
The visibility attribute is a GCC 4+ feature.
GCC 2.95 also warns about the unsigned/signed comparision.

This is a backport of libsecp256k1 PR773

Test Plan:

ninja check-secp256k1

I do not have GCC 2.95 installed, so I'll trust this is fixing the problem.

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D7594

Details

Provenance
Gregory Maxwell <greg@xiph.org>Authored on Jul 26 2020, 05:25
deadalnixCommitted on Sep 27 2020, 23:04
deadalnixPushed on Sep 27 2020, 23:04
Reviewer
Restricted Project
Differential Revision
D7594: Fix some compile problems on weird/old compilers.
Parents
rABC42bcef68620e: Fix uninit values passed into cmov
Branches
Unknown
Tags
Unknown