Page MenuHomePhabricator

Fix some compile problems on weird/old compilers.
ClosedPublic

Authored by deadalnix on Sun, Sep 27, 22:35.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC1c79f821e744: Fix some compile problems on weird/old compilers.
Summary

The visibility attribute is a GCC 4+ feature.
GCC 2.95 also warns about the unsigned/signed comparision.

This is a backport of libsecp256k1 PR773

Test Plan
ninja check-secp256k1

I do not have GCC 2.95 installed, so I'll trust this is fixing the problem.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Sun, Sep 27, 23:03