Page MenuHomePhabricator
Differential D7594

Fix some compile problems on weird/old compilers.
ClosedPublic
Actions

Authored by deadalnix on Sep 27 2020, 22:35.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC1c79f821e744: Fix some compile problems on weird/old compilers.
Summary

The visibility attribute is a GCC 4+ feature.
GCC 2.95 also warns about the unsigned/signed comparision.

This is a backport of libsecp256k1 PR773

Test Plan
ninja check-secp256k1

I do not have GCC 2.95 installed, so I'll trust this is fixing the problem.

Diff Detail

Event Timeline

deadalnix created this revision.Sep 27 2020, 22:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2020, 22:35
deadalnix requested review of this revision.Sep 27 2020, 22:35
teamcity edited the summary of this revision. (Show Details)Sep 27 2020, 22:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12959: Diff 23853.Sep 27 2020, 22:51
majcosta accepted this revision.Sep 27 2020, 23:03
This revision is now accepted and ready to land.Sep 27 2020, 23:03
Closed by commit rABC1c79f821e744: Fix some compile problems on weird/old compilers. (authored by Gregory Maxwell <greg@xiph.org>, committed by deadalnix). · Explain WhySep 27 2020, 23:04
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC1c79f821e744: Fix some compile problems on weird/old compilers..

Revision Contents
Changeset List

PathSize
src/
secp256k1/
include/
2 lines
src/
2 lines

Diff 23853

View Options

src/secp256k1/include/secp256k1.h

Loading...
View Options

src/secp256k1/src/secp256k1.c

Loading...