HomePhabricator

Merge #11565: Make listsinceblock refuse unknown block hash

Description

Merge #11565: Make listsinceblock refuse unknown block hash

Summary:
659b206 Make listsinceblock refuse unknown block hash (Russell Yanofsky)

Pull request description:

Change suggested by @theuni  who noticed listsinceblock would ignore invalid block hashes causing it to return a completely unfiltered list of transactions.

Tree-SHA512: 3c8fb160265780d1334e856e853ab48e2e18372b8f1fc71ae480c3f45317048cc1fee0055d5c58031981a91b9c2bdbeb8e49a889d04ecba61729ce8109f2ce3f

Backport of Core PR 11565
https://github.com/bitcoin/bitcoin/pull/11565/files
Completes T563

Test Plan:
ninja check
wallet_listsinceblock.py

Reviewers: deadalnix, Fabien, #bitcoin_abc

Reviewed By: Fabien, #bitcoin_abc

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2703

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Nov 1 2017, 13:12
jasonbcoxCommitted on Mar 20 2019, 16:23
jasonbcoxPushed on Mar 20 2019, 16:23
Reviewer
Restricted Project
Differential Revision
D2703: Merge #11565: Make listsinceblock refuse unknown block hash
Parents
rABCc22ea26bba07: refactor: remove usage of locale dependent std::isspace
Branches
Unknown
Tags
Unknown