Merge #11565: Make listsinceblock refuse unknown block hash
ClosedPublic
Actions

Authored by jasonbcox on Mar 19 2019, 00:24.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING1d6970e88741: Merge #11565: Make listsinceblock refuse unknown block hash
rABC1d6970e88741: Merge #11565: Make listsinceblock refuse unknown block hash

Summary

659b206 Make listsinceblock refuse unknown block hash (Russell Yanofsky)

Pull request description:

Change suggested by @theuni  who noticed listsinceblock would ignore invalid block hashes causing it to return a completely unfiltered list of transactions.

Tree-SHA512: 3c8fb160265780d1334e856e853ab48e2e18372b8f1fc71ae480c3f45317048cc1fee0055d5c58031981a91b9c2bdbeb8e49a889d04ecba61729ce8109f2ce3f

Backport of Core PR 11565
https://github.com/bitcoin/bitcoin/pull/11565/files
Completes T563

Test Plan

ninja check
wallet_listsinceblock.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Mar 19 2019, 00:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2019, 00:24

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5239: Diff 7733.Mar 19 2019, 00:39

Fabien accepted this revision.Mar 19 2019, 15:41

This revision is now accepted and ready to land.Mar 19 2019, 15:41

Closed by commit rABC1d6970e88741: Merge #11565: Make listsinceblock refuse unknown block hash (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMar 20 2019, 16:23

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING1d6970e88741: Merge #11565: Make listsinceblock refuse unknown block hash.Sep 18 2019, 22:45

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

3 lines

src/

wallet/

rpcwallet.cpp

19 lines

test/

functional/

wallet_listsinceblock.py

35 lines

Diff 7756

View Options

doc/release-notes.md

View Options

src/wallet/rpcwallet.cpp

View Options

test/functional/wallet_listsinceblock.py

Merge #11565: Make listsinceblock refuse unknown block hashClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7756

doc/release-notes.md

src/wallet/rpcwallet.cpp

test/functional/wallet_listsinceblock.py

Merge #11565: Make listsinceblock refuse unknown block hash
ClosedPublic
Actions

Revision Contents
Changeset List