HomePhabricator

net: Improve and document SOCKS code

Description

net: Improve and document SOCKS code

Summary:
Make the SOCKS code more consistent, and document the constants used.

This is a backport of Core PR11397

Depends on D1872

Test Plan:

make check

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: jasonbcox, teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1873

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Sep 23 2017, 08:36
deadalnixCommitted on Oct 5 2018, 09:24
deadalnixPushed on Oct 5 2018, 09:24
Reviewer
Restricted Project
Differential Revision
D1873: net: Improve and document SOCKS code
Parents
rABC235da3f8f63f: Move CloseSocket out of SetSocketNonBlocking and pass SOCKET by const reference…
Branches
Unknown
Tags
Unknown

Event Timeline