HomePhabricator

refactor, miner: Delete call to UpdatePackagesForAdded at beginning of…

Description

refactor, miner: Delete call to UpdatePackagesForAdded at beginning of addPackageTxs

Summary:

In CreateNewBlock (in miner.cpp), inBlock is cleared before addPackageTxs, so inBlock will be empty in the first call to UpdatePackagesForAdded

Since this is the only callsite, there is no change in behavior.

Backport of core#24934.

Depends on D12954.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D12955

Details

Provenance
KevinMusgrave <tkm45@cornell.edu>Authored on Apr 21 2022, 00:43
FabienCommitted on Jan 6 2023, 18:41
FabienPushed on Jan 6 2023, 18:41
Reviewer
Restricted Project
Differential Revision
D12955: refactor, miner: Delete call to UpdatePackagesForAdded at beginning of addPackageTxs
Parents
rABCce0b1b9a2436: refactor: remove duplicate code from BlockAssembler
Branches
Unknown
Tags
Unknown