HomePhabricator

[wallet] Pass error message back from CWallet::Verify()

Authored by John Newbery <john@johnnewbery.com> on Apr 18 2018, 18:17.

Description

[wallet] Pass error message back from CWallet::Verify()

Summary:

Pass an error message back from CWallet::Verify(), and call
InitError/InitWarning from WalletInit::Verify().

This means that we can call CWallet::Verify() independently from
WalletInit and not have InitErrors printed to stdout. It also means that
the error can be reported to the user if dynamic wallet load fails.

Partial backport of core PR10740 (commit 876eb64)
https://github.com/bitcoin/bitcoin/pull/10740/commits/876eb64680968c8fe2a28d1ecfd88a08d8967ead

Depends on D3632

Progress towards T459

Test Plan:

make check
./test/functional/test_runner.py wallet_*

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3635

Details

Committed
FabienJul 11 2019, 20:12
Pushed
FabienJul 11 2019, 20:12
Reviewer
Restricted Project
Differential Revision
D3635: [wallet] Pass error message back from CWallet::Verify()
Parents
rABCf0f17ff571bc: Place sanitizers log into their own directory
Branches
Unknown
Tags
Unknown