Page MenuHomePhabricator

[wallet] Pass error message back from CWallet::Verify()
ClosedPublic

Authored by Fabien on Jul 10 2019, 14:33.

Details

Summary
Pass an error message back from CWallet::Verify(), and call
InitError/InitWarning from WalletInit::Verify().

This means that we can call CWallet::Verify() independently from
WalletInit and not have InitErrors printed to stdout. It also means that
the error can be reported to the user if dynamic wallet load fails.

Partial backport of core PR10740 (commit 876eb64)
https://github.com/bitcoin/bitcoin/pull/10740/commits/876eb64680968c8fe2a28d1ecfd88a08d8967ead

Depends on D3632

Progress towards T459

Test Plan
make check
./test/functional/test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jul 10 2019, 14:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2019, 14:33
deadalnix accepted this revision.Jul 10 2019, 15:07
This revision is now accepted and ready to land.Jul 10 2019, 15:07