Page MenuHomePhabricator
Differential D3635

[wallet] Pass error message back from CWallet::Verify()
ClosedPublic
Actions

Authored by Fabien on Jul 10 2019, 14:33.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING62ae155ee7f6: [wallet] Pass error message back from CWallet::Verify()
rABC62ae155ee7f6: [wallet] Pass error message back from CWallet::Verify()
Summary
Pass an error message back from CWallet::Verify(), and call
InitError/InitWarning from WalletInit::Verify().

This means that we can call CWallet::Verify() independently from
WalletInit and not have InitErrors printed to stdout. It also means that
the error can be reported to the user if dynamic wallet load fails.

Partial backport of core PR10740 (commit 876eb64)
https://github.com/bitcoin/bitcoin/pull/10740/commits/876eb64680968c8fe2a28d1ecfd88a08d8967ead

Depends on D3632

Progress towards T459

Test Plan
make check
./test/functional/test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10740_part4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6798
Build 11643: Bitcoin ABC Buildbot (legacy)
Build 11642: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 10 2019, 14:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2019, 14:33
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 10 2019, 14:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 10 2019, 14:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B6798: Diff 10195!Jul 10 2019, 14:39
deadalnix accepted this revision.Jul 10 2019, 15:07
This revision is now accepted and ready to land.Jul 10 2019, 15:07
Fabien added a child revision: D3636: [wallet] [rpc] Add loadwallet RPC.Jul 10 2019, 15:18
teamcity added a comment.Jul 11 2019, 20:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 11 2019, 20:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6798: Diff 10195.Jul 11 2019, 20:11
Closed by commit rABC62ae155ee7f6: [wallet] Pass error message back from CWallet::Verify() (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJul 11 2019, 20:12
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC62ae155ee7f6: [wallet] Pass error message back from CWallet::Verify().
Fabien added a commit: rSTAGING62ae155ee7f6: [wallet] Pass error message back from CWallet::Verify().Sep 19 2019, 01:12

Revision Contents
Changeset List

PathSize
src/
wallet/
13 lines
3 lines
46 lines

Diff 10195

View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...