HomePhabricator

Place sanitizers log into their own directory

Authored by Fabien on Thu, Jul 11, 17:15.

Description

Place sanitizers log into their own directory

Summary:
This diff will make the sanitizers to output to a log file rather than
stderr, which has some advantages:

  • This will prevent unrelated failures in functional tests, as some

assertion are checking the stderr output;

  • This will allow for pushing the log files to the artifact list;
  • This will make it easier to debug the failures, as related things

are kept together.

As a disadvantage when a sanitizer throw an error it will output nothing
to the console but still fail, creating a "failure for no visible
reason" output. This is mitigated by printing the log file after the tests if
they exist.

Test Plan: See teamcity output, or reproduce locally with the same options.

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D3651

Details

Committed
FabienThu, Jul 11, 20:05
Pushed
FabienThu, Jul 11, 20:05
Reviewer
Restricted Project
Differential Revision
D3651: Place sanitizers log into their own directory
Parents
rABC4d4fca502dac: Avoid std::locale/imbue in DateTimeStrFormat
Branches
Unknown
Tags
Unknown