Page MenuHomePhabricator

Place sanitizers log into their own directory
ClosedPublic

Authored by Fabien on Jul 11 2019, 17:16.

Details

Summary

This diff will make the sanitizers to output to a log file rather than
stderr, which has some advantages:

  • This will prevent unrelated failures in functional tests, as some

assertion are checking the stderr output;

  • This will allow for pushing the log files to the artifact list;
  • This will make it easier to debug the failures, as related things

are kept together.

As a disadvantage when a sanitizer throw an error it will output nothing
to the console but still fail, creating a "failure for no visible
reason" output. This is mitigated by printing the log file after the tests if
they exist.

Test Plan

See teamcity output, or reproduce locally with the same options.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jul 11 2019, 17:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2019, 17:16
jasonbcox edited the summary of this revision. (Show Details)Jul 11 2019, 17:45
jasonbcox requested changes to this revision.Jul 11 2019, 17:49
jasonbcox added a subscriber: jasonbcox.

The disadvantage is pretty bad, especially for new developers. Please make sure the output is still duplicated to stderr or something similar.

This revision now requires changes to proceed.Jul 11 2019, 17:49
Fabien updated this revision to Diff 10237.Jul 11 2019, 19:13

Print the logs if they exist.

Fabien edited the summary of this revision. (Show Details)Jul 11 2019, 19:13
jasonbcox accepted this revision.Jul 11 2019, 19:33
This revision is now accepted and ready to land.Jul 11 2019, 19:33
This revision was automatically updated to reflect the committed changes.