Page MenuHomePhabricator

Place sanitizers log into their own directory
ClosedPublic

Authored by Fabien on Jul 11 2019, 17:16.

Details

Summary

This diff will make the sanitizers to output to a log file rather than
stderr, which has some advantages:

  • This will prevent unrelated failures in functional tests, as some

assertion are checking the stderr output;

  • This will allow for pushing the log files to the artifact list;
  • This will make it easier to debug the failures, as related things

are kept together.

As a disadvantage when a sanitizer throw an error it will output nothing
to the console but still fail, creating a "failure for no visible
reason" output. This is mitigated by printing the log file after the tests if
they exist.

Test Plan

See teamcity output, or reproduce locally with the same options.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
teamcity_san_build_to_log
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6822
Build 11691: Bitcoin ABC Buildbot (legacy)
Build 11690: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Jul 11 2019, 17:49
jasonbcox added a subscriber: jasonbcox.

The disadvantage is pretty bad, especially for new developers. Please make sure the output is still duplicated to stderr or something similar.

This revision now requires changes to proceed.Jul 11 2019, 17:49

Print the logs if they exist.

This revision is now accepted and ready to land.Jul 11 2019, 19:33