Paths

Table of Contentst

[util] Replace use of locale dependent atoi(…) with locale-independent std…
732fc5fb4c67
Actions

Description

[util] Replace use of locale dependent atoi(…) with locale-independent std::from_chars (C++17)

Summary:
Removes the usage of atoi, which is not locale-independent, and replaces it with a new function LocaleIndependentAtoi, which is.

test: Add test cases for LocaleIndependentAtoi
fuzz: Assert legacy atoi(s) == LocaleIndependentAtoi<int>(s)
fuzz: Assert legacy atoi64(s) == LocaleIndependentAtoi<int64_t>(s)

Backport from core#20452.

Test Plan: ninja check, plus run fuzzers

Reviewers: Fabien, #bitcoin_abc

Reviewed By: Fabien, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D18472

Details

Provenance

tobias_ruck	Authored on Aug 11 2025, 13:23
tobias_ruck	Pushed on Aug 11 2025, 15:59

Reviewer

Restricted Project

Differential Revision

D18472: [util] Replace use of locale dependent atoi(…) with locale-independent std::from_chars (C++17)

Parents

rABC302d6904beec: Bump version to 0.31.10

Branches

Unknown

Tags

Unknown

Event Timeline

tobias_ruck committed rABC732fc5fb4c67: [util] Replace use of locale dependent atoi(…) with locale-independent std… (authored by tobias_ruck).Aug 11 2025, 15:59

tobias_ruck added an edge: D18472: [util] Replace use of locale dependent atoi(…) with locale-independent std::from_chars (C++17).

teamcity mentioned this in T3858: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken..Aug 11 2025, 16:24

Changes (16)

Path

Size

arcanist/

linter/

LocaleDependenceLinter.php

src/

common/

node/

qt/

rpc/

seeder/

test/

fuzz/

util/

wallet/

rABC732fc5fb4c67

View Options

arcanist/linter/LocaleDependenceLinter.php

View Options

src/common/args.cpp

View Options

src/core_read.cpp

View Options

src/node/blockstorage.cpp

View Options

src/qt/rpcconsole.cpp

View Options

src/rpc/mining.cpp

View Options

src/seeder/options.cpp

View Options

src/test/fuzz/locale.cpp

View Options

src/test/fuzz/parse_numbers.cpp

View Options

src/test/fuzz/string.cpp

View Options

src/test/util_tests.cpp

View Options

src/torcontrol.cpp

View Options

src/util/moneystr.cpp

View Options

src/util/strencodings.cpp

View Options

src/util/strencodings.h

View Options

[util] Replace use of locale dependent atoi(…) with locale-independent std…732fc5fb4c67Actions

Description

Details

Event Timeline

Changes (16)

rABC732fc5fb4c67

arcanist/linter/LocaleDependenceLinter.php

src/common/args.cpp

src/core_read.cpp

src/node/blockstorage.cpp

src/qt/rpcconsole.cpp

src/rpc/mining.cpp

src/seeder/options.cpp

src/test/fuzz/locale.cpp

src/test/fuzz/parse_numbers.cpp

src/test/fuzz/string.cpp

src/test/util_tests.cpp

src/torcontrol.cpp

src/util/moneystr.cpp

src/util/strencodings.cpp

src/util/strencodings.h

src/wallet/transaction.h

[util] Replace use of locale dependent atoi(…) with locale-independent std…
732fc5fb4c67
Actions