HomePhabricator

[backport#17889] wallet: Improve CWallet:MarkDestinationsDirty

Description

[backport#17889] wallet: Improve CWallet:MarkDestinationsDirty

Summary:
2b1641492fbf81e2c5a95f3e580811ca8700adc5 wallet: Improve CWallet:MarkDestinationsDirty (João Barbosa)

Pull request description:

Improve `CWallet:MarkDestinationsDirty` by skipping transactions that already have the cache invalidated. Skipping a transaction avoids at worst case extracting all output destinations.

Depends on D7685

Backport of Core PR17889

Test Plan:

ninja all check check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7801

Details

Provenance
Samuel Dobson <dobsonsa68@gmail.com>Authored on Jan 17 2020, 01:15
majcostaCommitted on Oct 7 2020, 18:59
majcostaPushed on Oct 7 2020, 18:59
Reviewer
Restricted Project
Differential Revision
D7801: [backport#17889] wallet: Improve CWallet:MarkDestinationsDirty
Parents
rABC31dc3e9d90f5: [backport#17843] wallet: Reset reused transactions cache
Branches
Unknown
Tags
Unknown