HomePhabricator

[tests] remove txdb.h dependency from test_bitcoin.h

Description

[tests] remove txdb.h dependency from test_bitcoin.h

Summary:
txdb.h is the one unnecessary dependency in test_bitcoin.h. It brings in
some heavy dependencies via chain.h and coins.h that result in unnecessary
recompilation work when various headers are changed.

Unfortunately numerous tests were relying on hidden indirect imports via
test_bitcoin.h -> txdb.h -> ??, so these tests needed the correct headers
to be added in.

Test Plan: compile

Reviewers: #bitcoin_abc, deadalnix, Fabien, jasonbcox

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D2963

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC822224e62410: [tests] remove txdb.h dependency from test_bitcoin.h (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).May 10 2019, 20:44