Differential D2963

[tests] remove txdb.h dependency from test_bitcoin.h
ClosedPublic
Actions

Authored by markblundeberg on May 7 2019, 03:43.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING822224e62410: [tests] remove txdb.h dependency from test_bitcoin.h
rABC822224e62410: [tests] remove txdb.h dependency from test_bitcoin.h

Summary

txdb.h is the one unnecessary dependency in test_bitcoin.h. It brings in
some heavy dependencies via chain.h and coins.h that result in unnecessary
recompilation work when various headers are changed.

Unfortunately numerous tests were relying on hidden indirect imports via
test_bitcoin.h -> txdb.h -> ??, so these tests needed the correct headers
to be added in.

Test Plan

compile

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markblundeberg created this revision.May 7 2019, 03:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2019, 03:43

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B5722: Diff 8451!May 7 2019, 03:51

markblundeberg planned changes to this revision.May 7 2019, 03:52

markblundeberg added reviewers: Fabien, jasonbcox.May 7 2019, 04:04

wasn't building qt on my build machine so I missed the qt tests ...

fix qt test too

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5724: Diff 8453.May 7 2019, 07:03

Fabien requested changes to this revision.May 7 2019, 07:10

Fabien added inline comments.

src/test/hash_tests.cpp
7 ↗	(On Diff #8453)	Leave these 2 files in their own section, they are the purpose of the test
src/test/merkle_tests.cpp
6 ↗	(On Diff #8453)	Dito, add a newline before the new include
src/test/sighashtype_tests.cpp
6 ↗	(On Diff #8453)	Dito

This revision now requires changes to proceed.May 7 2019, 07:10

leave test-subject headers in first header block

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5731: Diff 8463.May 7 2019, 15:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.May 10 2019, 19:01

This revision is now accepted and ready to land.May 10 2019, 19:01

Closed by commit rABC822224e62410: [tests] remove txdb.h dependency from test_bitcoin.h (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 10 2019, 20:44

This revision was automatically updated to reflect the committed changes.

nakihito mentioned this in D4106: Merge #13234: Break circular dependency: chain -> pow -> chain.Sep 18 2019, 22:18

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING822224e62410: [tests] remove txdb.h dependency from test_bitcoin.h.Sep 18 2019, 23:29

Revision Contents
Changeset List

Path

Size

src/

qt/

test/

wallettests.cpp

1 line

test/

1 line

bip32_tests.cpp

2 lines

blockencodings_tests.cpp

2 lines

cashaddrenc_tests.cpp

1 line

coins_tests.cpp

2 lines

finalization_tests.cpp

2 lines

2 lines

merkle_tests.cpp

2 lines

miner_tests.cpp

1 line

multisig_tests.cpp

1 line

script_tests.cpp

1 line

serialize_tests.cpp

1 line

sigcache_tests.cpp

2 lines

sighashtype_tests.cpp

2 lines

1 line

transaction_tests.cpp

2 lines

txvalidationcache_tests.cpp

1 line

uint256_tests.cpp

1 line

1 line

validation_tests.cpp

2 lines

wallet/

test/

wallet_tests.cpp

1 line

Diff 8606

src/qt/test/wallettests.cpp

Loading...

src/test/DoS_tests.cpp

Loading...

src/test/bip32_tests.cpp

Loading...

src/test/blockencodings_tests.cpp

Loading...

src/test/cashaddrenc_tests.cpp

Loading...

src/test/coins_tests.cpp

Loading...

src/test/finalization_tests.cpp

Loading...

src/test/hash_tests.cpp

Loading...

src/test/merkle_tests.cpp

Loading...

src/test/miner_tests.cpp

Loading...

src/test/multisig_tests.cpp

Loading...

src/test/script_tests.cpp

Loading...

src/test/serialize_tests.cpp

Loading...

src/test/sigcache_tests.cpp

Loading...

src/test/sighashtype_tests.cpp

Loading...

src/test/test_bitcoin.h

Loading...

src/test/transaction_tests.cpp

Loading...

src/test/txvalidationcache_tests.cpp

Loading...

src/test/uint256_tests.cpp

Loading...

src/test/undo_tests.cpp

Loading...

src/test/validation_tests.cpp

Loading...

src/wallet/test/wallet_tests.cpp

Loading...