Paths

Table of Contentst

chain
ClosedPublic
Actions

Authored by nakihito on Sep 18 2019, 22:15.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGe97fe1774460: Merge #13234: Break circular dependency: chain -> pow -> chain
rABCe97fe1774460: Merge #13234: Break circular dependency: chain -> pow -> chain

Summary

5b35b92 Break circular dependency: chain -> pow -> chain (Ben Woosley)

Pull request description:

chain.h does not actually depend on the methods defined in pow.h, just its
include of consensus/params.h, which is standalone and can be included instead.

Confirmed by inspection and successful build.

Tree-SHA512: fd2a182aad72c62ca54c9ac028d8f3f4416e4d0a5b8ed0a23fb52496d9291a6eeed5252f5e8b8ef4e47ca28bea3d2ed6ff3c41ddb92d102af02a895c9787100c

Backport of Core PR13234
https://github.com/bitcoin/bitcoin/pull/13234/

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Sep 18 2019, 22:15

Owners added a reviewer: Restricted Owners Package.Sep 18 2019, 22:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 18 2019, 22:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

Change to blockencodings_test.cpp added here: https://reviews.bitcoinabc.org/D2963#change-91PbLYuFIU2s

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7505: Diff 11520.Sep 18 2019, 22:26

deadalnix accepted this revision.Sep 19 2019, 08:12

This revision is now accepted and ready to land.Sep 19 2019, 08:12

Closed by commit rABCe97fe1774460: Merge #13234: Break circular dependency: chain -> pow -> chain (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhySep 19 2019, 17:31

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCe97fe1774460: Merge #13234: Break circular dependency: chain -> pow -> chain.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGe97fe1774460: Merge #13234: Break circular dependency: chain -> pow -> chain.Sep 27 2019, 22:45

Revision Contents
Changeset List

Path

Size

src/

chain.h

1 line

test/

test_bitcoin.cpp

1 line

Diff 13016

View Options

src/chain.h