HomePhabricator

Merge #13234: Break circular dependency: chain -> pow -> chain

Description

Merge #13234: Break circular dependency: chain -> pow -> chain

Summary:
5b35b92 Break circular dependency: chain -> pow -> chain (Ben Woosley)

Pull request description:

chain.h does not actually depend on the methods defined in pow.h, just its
include of consensus/params.h, which is standalone and can be included instead.

Confirmed by inspection and successful build.

Tree-SHA512: fd2a182aad72c62ca54c9ac028d8f3f4416e4d0a5b8ed0a23fb52496d9291a6eeed5252f5e8b8ef4e47ca28bea3d2ed6ff3c41ddb92d102af02a895c9787100c

Backport of Core PR13234
https://github.com/bitcoin/bitcoin/pull/13234/

Test Plan:

make check

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4106

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on May 15 2018, 07:38
nakihitoCommitted on Sep 19 2019, 17:31
nakihitoPushed on Sep 19 2019, 17:31
Reviewer
Restricted Owners Package
Differential Revision
D4106: Merge #13234: Break circular dependency: chain -> pow -> chain
Parents
rABCacc1dbbebdfc: Partial Merge #12920: test: Fix sign for expected values
Branches
Unknown
Tags
Unknown