HomePhabricator

Partial Merge #12920: test: Fix sign for expected values

Description

Partial Merge #12920: test: Fix sign for expected values

Summary:
c55aa4f test: Fix sign for expected values (Karl-Johan Alm)

Pull request description:

A number of `BOOST_CHECK_EQUAL` calls would result in warnings about signs.

This PR fixes signedness for all expectation values, sometimes resulting in `int` → `unsigned int`. No other code changes besides adding/removing `U` to/from values.

Running `make &> make_output_...` on master versus on this PR:
```
$ wc make_output_*
    1464    5925   90357 make_output_master
     613    1469   28370 make_output_signfixed
```
More than halves the output lines from compiling.

Tree-SHA512: b06c9fb81704fd32a6a61fe7b2ceb5f1bb381e9873d79e13d7e4d26bbd9b67c9725a84e6fb2903bcda775aea2a792e544b0799d36735c19f5d1c7225e8c6d14e

Partial Backport of Core PR12920
https://github.com/bitcoin/bitcoin/pull/12920/

Same as D3882, but excludes code dependent on PR11293

Test Plan:

make check

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix, Fabien, jasonbcox

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4104

Details

Provenance
nakihitoAuthored on Aug 12 2019, 21:31
nakihitoPushed on Sep 19 2019, 17:26
Reviewer
Restricted Owners Package
Differential Revision
D4104: Partial Merge #12920: test: Fix sign for expected values
Parents
rABCb9259709840e: Merge #13431: validation: count blocks correctly for check level < 3
Branches
Unknown
Tags
Unknown