Differential D4104

Partial Merge #12920: test: Fix sign for expected values
ClosedPublic
Actions

Authored by nakihito on Sep 18 2019, 19:39.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGacc1dbbebdfc: Partial Merge #12920: test: Fix sign for expected values
rABCacc1dbbebdfc: Partial Merge #12920: test: Fix sign for expected values

Summary

c55aa4f test: Fix sign for expected values (Karl-Johan Alm)

Pull request description:

A number of `BOOST_CHECK_EQUAL` calls would result in warnings about signs.

This PR fixes signedness for all expectation values, sometimes resulting in `int` → `unsigned int`. No other code changes besides adding/removing `U` to/from values.

Running `make &> make_output_...` on master versus on this PR:
```
$ wc make_output_*
    1464    5925   90357 make_output_master
     613    1469   28370 make_output_signfixed
```
More than halves the output lines from compiling.

Tree-SHA512: b06c9fb81704fd32a6a61fe7b2ceb5f1bb381e9873d79e13d7e4d26bbd9b67c9725a84e6fb2903bcda775aea2a792e544b0799d36735c19f5d1c7225e8c6d14e

Partial Backport of Core PR12920
https://github.com/bitcoin/bitcoin/pull/12920/

Same as D3882, but excludes code dependent on PR11293

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito planned changes to this revision.Sep 18 2019, 19:39

nakihito created this revision.

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito requested review of this revision.Sep 18 2019, 19:49

nakihito retitled this revision from Merge #12920: test: Fix sign for expected values to Partial Merge #12920: test: Fix sign for expected values.

nakihito edited the summary of this revision. (Show Details)

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7503: Diff 11386.Sep 18 2019, 19:55

deadalnix accepted this revision.Sep 19 2019, 08:14

This revision is now accepted and ready to land.Sep 19 2019, 08:14

Closed by commit rABCacc1dbbebdfc: Partial Merge #12920: test: Fix sign for expected values (authored by nakihito). · Explain WhySep 19 2019, 17:26

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCacc1dbbebdfc: Partial Merge #12920: test: Fix sign for expected values.

nakihito mentioned this in D3882: Merge #12920: test: Fix sign for expected values.Sep 24 2019, 23:35

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGacc1dbbebdfc: Partial Merge #12920: test: Fix sign for expected values.Sep 27 2019, 22:45

Revision Contents
Changeset List

Path

Size

src/

test/

addrman_tests.cpp

66 lines

allocator_tests.cpp

4 lines

coins_tests.cpp

6 lines

crypto_tests.cpp

4 lines

dbwrapper_tests.cpp

6 lines

32 lines

8 lines

random_tests.cpp

2 lines

script_standard_tests.cpp

24 lines

serialize_tests.cpp

54 lines

torcontrol_tests.cpp

4 lines

txvalidationcache_tests.cpp

6 lines

wallet/

test/

wallet_tests.cpp

18 lines

Diff 13015

src/test/addrman_tests.cpp

Loading...

src/test/allocator_tests.cpp

Loading...

src/test/coins_tests.cpp

Loading...

src/test/crypto_tests.cpp

Loading...

src/test/dbwrapper_tests.cpp

Loading...

src/test/hash_tests.cpp

Loading...

src/test/pow_tests.cpp

Loading...

src/test/random_tests.cpp

Loading...

src/test/script_standard_tests.cpp

Loading...

src/test/serialize_tests.cpp

Loading...

src/test/torcontrol_tests.cpp

Loading...

src/test/txvalidationcache_tests.cpp

Loading...

src/wallet/test/wallet_tests.cpp

Loading...