[tests] remove txdb.h dependency from test_bitcoin.h
ClosedPublic
Actions

Authored by markblundeberg on May 7 2019, 03:43.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING822224e62410: [tests] remove txdb.h dependency from test_bitcoin.h
rABC822224e62410: [tests] remove txdb.h dependency from test_bitcoin.h

Summary

txdb.h is the one unnecessary dependency in test_bitcoin.h. It brings in
some heavy dependencies via chain.h and coins.h that result in unnecessary
recompilation work when various headers are changed.

Unfortunately numerous tests were relying on hidden indirect imports via
test_bitcoin.h -> txdb.h -> ??, so these tests needed the correct headers
to be added in.

Test Plan

compile

Diff Detail

Repository

rABC Bitcoin ABC

Branch

test_nodep_txdb

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5722
Build 9506: Bitcoin ABC Buildbot (legacy)
Build 9505: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 7 2019, 03:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2019, 03:43

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B5722: Diff 8451!May 7 2019, 03:51

markblundeberg planned changes to this revision.May 7 2019, 03:52

markblundeberg added reviewers: Fabien, jasonbcox.May 7 2019, 04:04

wasn't building qt on my build machine so I missed the qt tests ...

fix qt test too

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5724: Diff 8453.May 7 2019, 07:03

Fabien requested changes to this revision.May 7 2019, 07:10

Fabien added inline comments.

src/test/hash_tests.cpp
7 ↗	(On Diff #8453)	Leave these 2 files in their own section, they are the purpose of the test
src/test/merkle_tests.cpp
6 ↗	(On Diff #8453)	Dito, add a newline before the new include
src/test/sighashtype_tests.cpp
6 ↗	(On Diff #8453)	Dito