Diffusion Bitcoin ABC 882287f84a67

test: Use COINBASE_MATURITY in functional tests
882287f84a67
Actions

Tags

None

Subscribers

None

Description

test: Use COINBASE_MATURITY in functional tests

Summary:

Goal of this PR is to replace integer constants with COINBASE_MATURITY but not necessarily in all cases because that would mean to read and fully understand all tests. That's out of my time constraints. Any reports where COINBASE_MATURITY should be used are welcome though!

Backport of core#21989.

Test Plan:
With chronik:

ninja check-functional-extended

Reviewers: #bitcoin_abc, roqqit

Reviewed By: roqqit

Subscribers: roqqit

Differential Revision: https://reviews.bitcoinabc.org/D16385

Details

Provenance

Kiminuo <kiminuo@protonmail.com>	Authored on May 17 2021, 14:38
Fabien	Committed on Fri, Jun 28, 19:10
Fabien	Pushed on Fri, Jun 28, 19:10

Reviewer

Differential Revision

D16385: test: Use COINBASE_MATURITY in functional tests

Parents

rABCa4ef4bb74be5: Use underscore in chronik-lib package name

Branches

Unknown

Tags

Unknown

Event Timeline

Fabien committed rABC882287f84a67: test: Use COINBASE_MATURITY in functional tests (authored by Kiminuo <kiminuo@protonmail.com>).Fri, Jun 28, 19:10

Fabien added an edge: D16385: test: Use COINBASE_MATURITY in functional tests.

Changes (78)

Path

Size

test/

functional/

abc-minimaldata.py

abc-schnorrmultisig.py

abc_mempool_chainedtx.py

abc_p2p_avalanche_transaction_voting.py

abc_p2p_proof_inventory.py

abc_rpc_avalancheproof.py

abc_rpc_isfinal.py

chronik_avalanche.py

chronik_block.py

chronik_block_info.py

chronik_block_txs.py

chronik_disable_token_index.py

chronik_lokad_id_group.py

chronik_mempool_conflicts.py

chronik_pause.py

chronik_raw_tx.py

chronik_script_utxos.py

chronik_spent_by.py

chronik_token_alp.py

chronik_token_broadcast_txs.py

chronik_token_burn.py

chronik_token_id_group.py

chronik_token_parse_failure.py

chronik_token_script_group.py

chronik_token_slp_fungible.py

chronik_token_slp_mint_vault.py

chronik_token_slp_nft1.py

chronik_tx_removal_order.py

chronik_ws_ordering.py

chronik_ws_script.py

feature_assumevalid.py

feature_coinstatsindex.py

feature_loadblock.py

feature_notifications.py

feature_utxo_set_hash.py

interface_bitcoin_cli.py

interface_rest.py

mempool_packages.py

mempool_reorg.py

p2p_compactblocks.py

p2p_eviction.py

p2p_invalid_block.py

p2p_invalid_tx.py

p2p_permissions.py

rpc_createmultisig.py

rpc_dumptxoutset.py

rpc_getblockstats.py

rpc_packages.py

rpc_signrawtransaction.py

setup_scripts/

chronik-client_broadcast_txs.py

chronik-client_lokad_id.py

chronik-client_mempool_conflicts.py

chronik-client_token_alp.py

chronik-client_token_slp_fungible.py

chronik-client_token_slp_mint_vault.py

chronik-client_token_slp_nft1.py

ecash-lib_base.py

test_framework/

wallet_abandonconflict.py

wallet_address_types.py

wallet_backup.py

wallet_balance.py

wallet_basic.py

wallet_coinbase_category.py

wallet_descriptor.py

wallet_groups.py

wallet_importdescriptors.py

wallet_importmulti.py

wallet_importprunedfunds.py

wallet_keypool_topup.py

wallet_labels.py

wallet_listsinceblock.py

wallet_multiwallet.py

wallet_watchonly.py

rABC882287f84a67

test/functional/abc-minimaldata.py

Loading...

test/functional/abc-schnorr.py

Loading...

test/functional/abc-schnorrmultisig.py

Loading...

test/functional/abc_mempool_chainedtx.py

Loading...

test/functional/abc_p2p_avalanche_transaction_voting.py

Loading...

test/functional/abc_p2p_proof_inventory.py

Loading...

test/functional/abc_rpc_avalancheproof.py

Loading...

test/functional/abc_rpc_isfinal.py

Loading...

test/functional/chronik_avalanche.py

Loading...

test/functional/chronik_block.py

Loading...

test/functional/chronik_block_info.py

Loading...

test/functional/chronik_block_txs.py

Loading...

test/functional/chronik_disable_token_index.py

Loading...

test/functional/chronik_lokad_id_group.py

Loading...

test/functional/chronik_mempool_conflicts.py

Loading...

test/functional/chronik_pause.py

Loading...

test/functional/chronik_raw_tx.py

Loading...

test/functional/chronik_script_utxos.py

Loading...

test/functional/chronik_spent_by.py

Loading...

test/functional/chronik_token_alp.py

Loading...

test/functional/chronik_token_broadcast_txs.py

Loading...

test/functional/chronik_token_burn.py

Loading...

test/functional/chronik_token_id_group.py

Loading...

test/functional/chronik_token_parse_failure.py

Loading...

test/functional/chronik_token_script_group.py

Loading...

test/functional/chronik_token_slp_fungible.py

Loading...

test/functional/chronik_token_slp_mint_vault.py

Loading...

test/functional/chronik_token_slp_nft1.py

Loading...

test/functional/chronik_tx.py

Loading...

test/functional/chronik_tx_removal_order.py

Loading...

test/functional/chronik_ws_ordering.py

Loading...

test/functional/chronik_ws_script.py

Loading...

test/functional/feature_assumevalid.py

Loading...

test/functional/feature_coinstatsindex.py

Loading...

test/functional/feature_loadblock.py

Loading...

test/functional/feature_notifications.py

Loading...

test/functional/feature_utxo_set_hash.py

Loading...

test/functional/interface_bitcoin_cli.py

Loading...

test/functional/interface_rest.py

Loading...

test/functional/mempool_packages.py

Loading...

test/functional/mempool_reorg.py

Loading...

test/functional/p2p_compactblocks.py

Loading...

test/functional/p2p_eviction.py

Loading...

test/functional/p2p_invalid_block.py

Loading...

test/functional/p2p_invalid_tx.py

Loading...

test/functional/p2p_permissions.py

Loading...

test/functional/rpc_createmultisig.py

Loading...

test/functional/rpc_dumptxoutset.py

Loading...

test/functional/rpc_getblockstats.py

Loading...

test/functional/rpc_packages.py

Loading...

test/functional/rpc_signrawtransaction.py

Loading...

test/functional/setup_scripts/chronik-client_broadcast_txs.py

Loading...

test/functional/setup_scripts/chronik-client_lokad_id.py

Loading...

test/functional/setup_scripts/chronik-client_mempool_conflicts.py

Loading...

test/functional/setup_scripts/chronik-client_token_alp.py

Loading...

test/functional/setup_scripts/chronik-client_token_slp_fungible.py

Loading...

test/functional/setup_scripts/chronik-client_token_slp_mint_vault.py

Loading...

test/functional/setup_scripts/chronik-client_token_slp_nft1.py

Loading...

test/functional/setup_scripts/ecash-lib_base.py

Loading...

test/functional/test_framework/blocktools.py

Loading...

test/functional/test_framework/cdefs.py

Loading...

test/functional/wallet_abandonconflict.py

Loading...

test/functional/wallet_address_types.py

Loading...

test/functional/wallet_backup.py

Loading...

test/functional/wallet_balance.py

Loading...

test/functional/wallet_basic.py

Loading...

test/functional/wallet_coinbase_category.py

Loading...

test/functional/wallet_descriptor.py

Loading...

test/functional/wallet_groups.py

Loading...

test/functional/wallet_hd.py

Loading...

test/functional/wallet_importdescriptors.py

Loading...

test/functional/wallet_importmulti.py

Loading...

test/functional/wallet_importprunedfunds.py

Loading...

test/functional/wallet_keypool_topup.py

Loading...

test/functional/wallet_labels.py

Loading...

test/functional/wallet_listsinceblock.py

Loading...

test/functional/wallet_multiwallet.py

Loading...

test/functional/wallet_watchonly.py

Loading...