Page MenuHomePhabricator

test: Use COINBASE_MATURITY in functional tests
ClosedPublic

Authored by Fabien on Fri, Jun 28, 13:28.

Details

Reviewers
roqqit
Group Reviewers
Restricted Project
Commits
rABC882287f84a67: test: Use COINBASE_MATURITY in functional tests
Summary
Goal of this PR is to replace integer constants with COINBASE_MATURITY but not necessarily in all cases because that would mean to read and fully understand all tests. That's out of my time constraints. Any reports where COINBASE_MATURITY should be used are welcome though!

Backport of core#21989.

Test Plan

With chronik:

ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Fri, Jun 28, 13:28
roqqit requested changes to this revision.Fri, Jun 28, 17:03
roqqit added a subscriber: roqqit.

One missing case in rpc_packages.py:47

This revision now requires changes to proceed.Fri, Jun 28, 17:03
This revision is now accepted and ready to land.Fri, Jun 28, 19:00
This revision was landed with ongoing or failed builds.Fri, Jun 28, 19:10
This revision was automatically updated to reflect the committed changes.