Differential D16386

test: Use MiniWallet in mempool_limit.py
ClosedPublic
Actions

Authored by Fabien on Fri, Jun 28, 14:14.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC4cd082c7e3b5: test: Use MiniWallet in mempool_limit.py

Summary

This PR enables running another non-wallet functional test even when the wallet is disabled thanks to the MiniWallet, i.e. it can be run even when bitcoin-core is compiled with --disable-wallet.

Backport of core#22543.

Depends on D16385.

Test Plan

With no wallet:

./test/functional/test_runner.py mempool_limit.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Fri, Jun 28, 14:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jun 28, 14:14

Fabien requested review of this revision.Fri, Jun 28, 14:14

teamcity edited the summary of this revision. (Show Details)Fri, Jun 28, 14:14

Fabien added a child revision: D16387: test: fix misleading fee unit in mempool_limit.py.Fri, Jun 28, 14:31

Harbormaster completed remote builds in B29409: Diff 48406.Fri, Jun 28, 14:32

roqqit requested changes to this revision.Fri, Jun 28, 17:12

roqqit added a subscriber: roqqit.

roqqit added inline comments.

test/functional/mempool_limit.py
88 ↗	(On Diff #48406)	this line is duplicated below

This revision now requires changes to proceed.Fri, Jun 28, 17:12

Fabien added inline comments.Fri, Jun 28, 18:55

test/functional/mempool_limit.py
88 ↗	(On Diff #48406)	Good catch

Deduplicate the log

roqqit accepted this revision.Fri, Jun 28, 19:01

This revision is now accepted and ready to land.Fri, Jun 28, 19:01

This revision was landed with ongoing or failed builds.Fri, Jun 28, 19:10

Closed by commit rABC4cd082c7e3b5: test: Use MiniWallet in mempool_limit.py (authored by ShubhamPalriwala <spalriwalau@gmail.com>, committed by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4cd082c7e3b5: test: Use MiniWallet in mempool_limit.py.

Harbormaster completed remote builds in B29412: Diff 48409.Fri, Jun 28, 19:19

Revision Contents
Changeset List

Path

Size

test/

functional/

mempool_limit.py

102 lines

Diff 48413

View Options

test/functional/mempool_limit.py

test: Use MiniWallet in mempool_limit.pyClosedPublicActions