Page MenuHomePhabricator
Differential D16386

test: Use MiniWallet in mempool_limit.py
ClosedPublic
Actions

Authored by Fabien on Jun 28 2024, 14:14.

Details

Reviewers
roqqit
Group Reviewers
Restricted Project
Commits
rABC4cd082c7e3b5: test: Use MiniWallet in mempool_limit.py
Summary
This PR enables running another non-wallet functional test even when the wallet is disabled thanks to the MiniWallet, i.e. it can be run even when bitcoin-core is compiled with --disable-wallet.

Backport of core#22543.

Depends on D16385.

Test Plan

With no wallet:

./test/functional/test_runner.py mempool_limit.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 28 2024, 14:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 28 2024, 14:14
Fabien requested review of this revision.Jun 28 2024, 14:14
teamcity edited the summary of this revision. (Show Details)Jun 28 2024, 14:14
Fabien added a child revision: D16387: test: fix misleading fee unit in mempool_limit.py.Jun 28 2024, 14:31
Harbormaster completed remote builds in B29409: Diff 48406.Jun 28 2024, 14:32
roqqit requested changes to this revision.Jun 28 2024, 17:12
roqqit added a subscriber: roqqit.
roqqit added inline comments.
test/functional/mempool_limit.py
88 ↗(On Diff #48406)

this line is duplicated below

This revision now requires changes to proceed.Jun 28 2024, 17:12
Fabien added inline comments.Jun 28 2024, 18:55
test/functional/mempool_limit.py
88 ↗(On Diff #48406)

Good catch

Fabien updated this revision to Diff 48409.Jun 28 2024, 18:59

Deduplicate the log

roqqit accepted this revision.Jun 28 2024, 19:01
This revision is now accepted and ready to land.Jun 28 2024, 19:01
This revision was landed with ongoing or failed builds.Jun 28 2024, 19:10
Closed by commit rABC4cd082c7e3b5: test: Use MiniWallet in mempool_limit.py (authored by ShubhamPalriwala <spalriwalau@gmail.com>, committed by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC4cd082c7e3b5: test: Use MiniWallet in mempool_limit.py.
Harbormaster completed remote builds in B29412: Diff 48409.Jun 28 2024, 19:19

Revision Contents
Changeset List

PathSize
test/
functional/
102 lines

Diff 48413

View Options

test/functional/mempool_limit.py

Loading...